Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 1137993005: Remove Media Router impl and BrowserContext factory. (Closed)

Created:
5 years, 7 months ago by Kevin M
Modified:
5 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, media-router+watch_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Media Router impl and BrowserContext factory. The class is now redundant with the Media Router Mojo impl class (to be landed in an upcoming CL.) BUG=461815 R=imcheng@chromium.org TBR=miu@chromium.org Committed: https://crrev.com/fe41362d4e128777cb7e9a98fb3a87c59d658af2 Cr-Commit-Position: refs/heads/master@{#329659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -259 lines) Patch
M chrome/browser/media/router/BUILD.gn View 3 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/media/router/media_router.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/media/router/media_router_impl.h View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/media/router/media_router_impl.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/media/router/media_router_impl_factory.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/media/router/media_router_impl_factory.cc View 1 chunk +0 lines, -47 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Kevin M
5 years, 7 months ago (2015-05-12 22:05:55 UTC) #1
imcheng (use chromium acct)
lgtm
5 years, 7 months ago (2015-05-12 22:09:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137993005/1
5 years, 7 months ago (2015-05-13 16:50:47 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-13 16:50:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137993005/1
5 years, 7 months ago (2015-05-13 16:57:26 UTC) #9
Kevin M
5 years, 7 months ago (2015-05-13 16:57:33 UTC) #11
miu
lgtm
5 years, 7 months ago (2015-05-13 16:58:23 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 17:04:23 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 17:06:14 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe41362d4e128777cb7e9a98fb3a87c59d658af2
Cr-Commit-Position: refs/heads/master@{#329659}

Powered by Google App Engine
This is Rietveld 408576698