Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1621)

Issue 1137993004: Revert of Restrict use of hardware-secure codecs based on the RendererPreference. (Closed)

Created:
5 years, 7 months ago by mdempsky
Modified:
5 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@setsecurity
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Restrict use of hardware-secure codecs based on the RendererPreference. (patchset #11 id:210001 of https://codereview.chromium.org/1124863005/) Reason for revert: Compile failure in KeySystemConfigSelectorTest::SelectConfig(). ../../media/blink/key_system_config_selector_unittest.cc:177:57: error: too few arguments to function call, expected 6, have 5 http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/113 Original issue's description: > Restrict use of hardware-secure codecs based on the RendererPreference. > > This passes the value of |use_video_overlay_for_embedded_encrypted_video| from RendererPreferences to requestMediaKeySystemAccess() so that it can correctly block either non-hardware-secure codecs or hardware-secure codecs. > > BUG=467779 > > Committed: https://crrev.com/491fea8c41977b1557a79cf2f53d4b60ecd159d9 > Cr-Commit-Position: refs/heads/master@{#329296} TBR=xhwang@chromium.org,ddorwin@chromium.org,nasko@chromium.org,sky@chromium.org,sandersd@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467779 Committed: https://crrev.com/ca9edf06f6a2fba3836ba888c3e008fbaf1ab232 Cr-Commit-Position: refs/heads/master@{#329307}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -75 lines) Patch
M components/html_viewer/html_document.cc View 2 chunks +1 line, -8 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M media/base/eme_constants.h View 1 chunk +7 lines, -6 lines 0 comments Download
M media/base/key_systems.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M media/blink/key_system_config_selector.h View 3 chunks +4 lines, -8 lines 0 comments Download
M media/blink/key_system_config_selector.cc View 10 chunks +11 lines, -17 lines 0 comments Download
M media/blink/webencryptedmediaclient_impl.h View 4 chunks +3 lines, -8 lines 0 comments Download
M media/blink/webencryptedmediaclient_impl.cc View 3 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mdempsky
Created Revert of Restrict use of hardware-secure codecs based on the RendererPreference.
5 years, 7 months ago (2015-05-12 01:15:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137993004/1
5 years, 7 months ago (2015-05-12 01:19:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 01:21:38 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 01:22:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca9edf06f6a2fba3836ba888c3e008fbaf1ab232
Cr-Commit-Position: refs/heads/master@{#329307}

Powered by Google App Engine
This is Rietveld 408576698