Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: tools/clang/plugins/tests/test.sh

Issue 1137973002: clang/win plugin: Do not warn on dllexport inline move constructors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/tests/missing_ctor_dllexport.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/tests/test.sh
diff --git a/tools/clang/plugins/tests/test.sh b/tools/clang/plugins/tests/test.sh
index cf262522eb855e291b8f769638bcddce0e9f7114..61bee99f82f229c44a58696e0c9537450ec11a81 100755
--- a/tools/clang/plugins/tests/test.sh
+++ b/tools/clang/plugins/tests/test.sh
@@ -31,8 +31,12 @@ do_testcase() {
flags="$(cat "${3}")"
fi
- if [ "$(uname -s)" = "Darwin" ]; then
- flags="${flags} -isysroot $(xcrun --show-sdk-path) -stdlib=libstdc++"
+ # TODO(thakis): Remove once the tests are standalone, http://crbug.com/486559
+ if [[ "$(uname -s)" == "Darwin" ]]; then
+ flags="${flags} -isysroot $(xcrun --show-sdk-path)"
+ fi
+ if [[ "$(uname -s)" == "Darwin" && "${flags}" != *-target* ]]; then
+ flags="${flags} -stdlib=libstdc++"
fi
flags="${flags} -Xclang -plugin-arg-find-bad-constructs \
« no previous file with comments | « tools/clang/plugins/tests/missing_ctor_dllexport.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698