Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1137933006: Add missing dependency of audio_unittests on xdisplaycheck. (Closed)

Created:
5 years, 7 months ago by watk
Modified:
5 years, 7 months ago
Reviewers:
jrummell
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing dependency of audio_unittests on xdisplaycheck. audio_unittests.isolate includes xdisplaycheck so audio_unittests should depend on it. BUG=416594 Committed: https://crrev.com/8bb590902960cdcd82c7302795496470eb8c4ab0 Cr-Commit-Position: refs/heads/master@{#330850}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M media/media.gyp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
watk
5 years, 7 months ago (2015-05-19 21:24:26 UTC) #2
jrummell
Question, since I don't understand the .isolate files: media_unittests.isolate (used right above the lines you ...
5 years, 7 months ago (2015-05-19 21:37:38 UTC) #3
watk
On 2015/05/19 21:37:38, jrummell wrote: > Question, since I don't understand the .isolate files: media_unittests.isolate ...
5 years, 7 months ago (2015-05-19 21:45:18 UTC) #4
jrummell
Thanks for checking. LGTM.
5 years, 7 months ago (2015-05-19 21:48:33 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137933006/1
5 years, 7 months ago (2015-05-20 20:20:27 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-20 22:19:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137933006/1
5 years, 7 months ago (2015-05-20 23:44:27 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 23:50:45 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 23:51:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bb590902960cdcd82c7302795496470eb8c4ab0
Cr-Commit-Position: refs/heads/master@{#330850}

Powered by Google App Engine
This is Rietveld 408576698