Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1137933004: Initialize members of CPDF_TextPageFind class. (Closed)

Created:
5 years, 7 months ago by Lei Zhang
Modified:
5 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M core/src/fpdftext/fpdf_text_int.cpp View 1 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Lei Zhang
I think these are reasonable defaults.
5 years, 7 months ago (2015-05-15 06:44:21 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1137933004/diff/1/core/src/fpdftext/fpdf_text_int.cpp File core/src/fpdftext/fpdf_text_int.cpp (right): https://codereview.chromium.org/1137933004/diff/1/core/src/fpdftext/fpdf_text_int.cpp#newcode2246 core/src/fpdftext/fpdf_text_int.cpp:2246: if (!pTextPage) { nit: is this even possible?
5 years, 7 months ago (2015-05-15 15:25:22 UTC) #3
Lei Zhang
https://codereview.chromium.org/1137933004/diff/1/core/src/fpdftext/fpdf_text_int.cpp File core/src/fpdftext/fpdf_text_int.cpp (right): https://codereview.chromium.org/1137933004/diff/1/core/src/fpdftext/fpdf_text_int.cpp#newcode2246 core/src/fpdftext/fpdf_text_int.cpp:2246: if (!pTextPage) { On 2015/05/15 15:25:22, Tom Sepez wrote: ...
5 years, 7 months ago (2015-05-15 22:19:07 UTC) #4
Lei Zhang
5 years, 7 months ago (2015-05-15 22:19:17 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
acae9257203971ee1e34d8d7573b7ba9a50041af (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698