Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Unified Diff: scripts/master/factory/chromium_commands.py

Issue 11379003: Add Windows ASAN bots. (Closed) Base URL: http://git.chromium.org/chromium/tools/build.git@neuter
Patch Set: Make things a little less (more?) ugly Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/master/factory/chromium_commands.py
diff --git a/scripts/master/factory/chromium_commands.py b/scripts/master/factory/chromium_commands.py
index 71ce3a97eb3a7e27f4a0d0553c8ef3fb024a7b2c..aed9f98fe4bccb2418748b060e1014c4cc6959b4 100644
--- a/scripts/master/factory/chromium_commands.py
+++ b/scripts/master/factory/chromium_commands.py
@@ -69,6 +69,7 @@ class ChromiumCommands(commands.FactoryCommands):
self._archive_tool = J(s_dir, 'archive_build.py')
self._sizes_tool = J(s_dir, 'sizes.py')
self._check_lkgr_tool = J(s_dir, 'check_lkgr.py')
+ self._windows_asan_tool = J(s_dir, 'win_apply_asan.py')
M-A Ruel 2012/11/27 20:40:15 I don't think it's useful unless it used multiple
iannucci 2012/11/28 03:19:34 It seemed more consistent with the existing code.
# Scripts in the private dir.
self._download_and_extract_official_tool = self.PathJoin(
@@ -133,6 +134,12 @@ class ChromiumCommands(commands.FactoryCommands):
self._factory.addStep(FileUpload(slavesrc=slavesrc,
masterdest=masterdest))
+ def AddWindowsASANStep(self):
+ """Adds a step to run syzygy/ASAN over the output directory."""
+ cmd = [self._python, self._windows_asan_tool,
+ '--build-dir', self._build_dir, '--target', self._target]
+ self.AddTestStep(shell.ShellCommand, 'apply_asan', cmd)
+
def AddArchiveBuild(self, mode='dev', show_url=True, factory_properties=None):
"""Adds a step to the factory to archive a build."""

Powered by Google App Engine
This is Rietveld 408576698