Add Windows ASAN bots.

scripts/master/factory/gclient_factory.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Utility classes to generate and manage a BuildFactory to be passed to a
 builder dictionary as the 'factory' member, for each builder in c['builders'].
 
 Specifically creates a base BuildFactory that will execute a gclient checkout
 first."""
 
@@ skipping 191 matching lines @@
           no_gclient_branch=no_gclient_branch)
     elif not delay_compile_step:
       self.AddUpdateStep(gclient_spec, factory_properties, factory,
                          slave_type, sudo_for_remove, gclient_deps=gclient_deps)
     return factory
 
   def BuildFactory(self, target='Release', clobber=False, tests=None, mode=None,
                    slave_type='BuilderTester', options=None,
                    compile_timeout=1200, build_url=None, project=None,
                    factory_properties=None, gclient_deps=None,
-                   target_arch=None):
+                   target_arch=None, add_archive_steps=True):

[nsylvain, 2012/11/27 00:23:15]

What about "skip_archive_steps=False" instead.  It makes it a bit more obvious
about what it does/

[iannucci, 2012/11/27 01:39:13]

Good call. Done.

     factory_properties = factory_properties or {}
     if options and '--build-tool=ninja' in options:
       factory_properties['gclient_env']['GYP_GENERATORS'] = 'ninja'
       if '--compiler=goma-clang' in options:
         # Ninja needs CC and CXX set at gyp time.
         factory_properties['gclient_env']['CC'] = 'clang'
         factory_properties['gclient_env']['CXX'] = 'clang++'
 
     # Create the spec for the solutions
     gclient_spec = self.BuildGClientSpec(tests)
 
     # Initialize the factory with the basic steps.
     factory = self.BaseFactory(gclient_spec,
                                factory_properties=factory_properties,
                                slave_type=slave_type,
                                gclient_deps=gclient_deps)
 
     # Get the factory command object to create new steps to the factory.
     factory_cmd_obj = commands.FactoryCommands(factory, target,
                                                self._build_dir,
                                                self._target_platform,
                                                target_arch)
 
     # Update clang if necessary.
     gclient_env = factory_properties.get('gclient_env', {})
     if ('clang=1' in gclient_env.get('GYP_DEFINES', '') or
-        'asan=1' in gclient_env.get('GYP_DEFINES', '')):
+        (self._target_platform != 'win32' and
+         'asan=1' in gclient_env.get('GYP_DEFINES', ''))):
       factory_cmd_obj.AddUpdateClangStep()
 
     # Add a step to cleanup temporary files and data left from a previous run
     # to prevent the drives from becoming full over time.
     factory_cmd_obj.AddTempCleanupStep()
 
     # Add the compile step if needed.
     if slave_type in ['BuilderTester', 'Builder', 'Trybot', 'Indexer']:
       factory_cmd_obj.AddCompileStep(
           project or self._project,
           clobber,
           mode=mode,
           options=options,
           timeout=compile_timeout,
           env=factory_properties.get('compile_env'))
 
-    # Archive the full output directory if the machine is a builder.
-    if slave_type == 'Builder':
-      factory_cmd_obj.AddZipBuild(halt_on_failure=True,
-                                  factory_properties=factory_properties)
+    if add_archive_steps:
+      # Archive the full output directory if the machine is a builder.
+      if slave_type == 'Builder':
+        factory_cmd_obj.AddZipBuild(halt_on_failure=True,
+                                    factory_properties=factory_properties)
 
-    # Download the full output directory if the machine is a tester.
-    if slave_type == 'Tester':
-      factory_cmd_obj.AddExtractBuild(build_url,
-                                      factory_properties=factory_properties)
+      # Download the full output directory if the machine is a tester.
+      if slave_type == 'Tester':
+        factory_cmd_obj.AddExtractBuild(build_url,
+                                        factory_properties=factory_properties)
 
     return factory
 
   # pylint: disable=R0201
   def TriggerFactory(self, factory, slave_type, factory_properties):
     """Add post steps on a build created by BuildFactory."""
     # Trigger any schedulers waiting on the build to complete.
     factory_properties = factory_properties or {}
     if factory_properties.get('trigger') is None:
       return
@@ skipping 64 matching lines @@
         no_gclient_revision=no_gclient_revision,
         gclient_transitive=gclient_transitive,
         primary_repo=primary_repo,
         gclient_jobs=gclient_jobs)
 
     if slave_type in ('AnnotatedTrybot', 'CrosTrybot', 'Trybot'):
       factory_cmd_obj.AddApplyIssueStep(timeout=timeout)
 
     if not self._nohooks_on_update:
       factory_cmd_obj.AddRunHooksStep(env=env, timeout=timeout)