Add Windows ASAN bots.

scripts/master/factory/commands.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Set of utilities to add commands to a buildbot factory (BuildFactory).
 
 All the utility functions to add steps to a build factory here are not
 project-specific. See the other *_commands.py for project-specific commands.
 """
 
@@ skipping 545 matching lines @@
     if total_shards and shard_index:
       cmd.extend(['--total-shards', str(total_shards),
                   '--shard-index', str(shard_index)])
 
     if test_name in factory_properties.get('sharded_tests', []):
       cmd.append('--parallel')
       sharding_args = factory_properties.get('sharding_args')
       if sharding_args:
         cmd.extend(['--sharding-args', sharding_args])
 
+    env = factory_properties.get('testing_env')

[nsylvain, 2012/11/27 00:23:15]

is this needed?

[iannucci, 2012/11/27 01:39:13]

Yes, because we need to set the CHROME_ALLOCATOR=WINHEAP env var during the test
step. See bottom of master_win_cfg.py.

+
     cmd.append(self.GetExecutableName(test_name))
 
     arg_list.append('--gtest_print_time')
     arg_list.append(WithProperties('%(gtest_filter)s'))
     cmd.extend(arg_list)
 
     self.AddTestStep(chromium_step.AnnotatedCommand, test_name,
                      ListProperties(cmd), description, do_step_if=doStep,
-                     br_do_step_if=brDoStep, hide_step_if=hideStep,
+                     env=env, br_do_step_if=brDoStep, hide_step_if=hideStep,
                      target=self._target, factory_properties=factory_properties)
 
   def AddBuildStep(self, factory_properties, name='build', env=None,
                    timeout=6000):
     """Add annotated step to use the buildrunner to run steps on the slave."""
 
     factory_properties['target'] = self._target
 
     cmd = [self._python, self._runbuild, '--annotate']
     cmd = self.AddBuildProperties(cmd)
@@ skipping 521 matching lines @@
 
   def commandComplete(self, cmd):
     out = cmd.logs['stdio'].getText()
     build_properties = re.findall('BUILD_PROPERTY ([^=]*)=(.*)', out)
     for propname, value in build_properties:
       # findall can return strings containing CR characters, remove with strip.
       self.build.setProperty(propname, value.strip(), 'Step')
 
   def getText(self, cmd, results):
     return self.describe(True) + self.messages