Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1137873006: cr-elements fixes for Polymer 0.8 (Closed)

Created:
5 years, 7 months ago by michaelpg
Modified:
5 years, 7 months ago
Reviewers:
jlklein, Jeremy Klein
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cr-elements fixes for Polymer 0.8 BUG=485381 TEST=manual R=jlklein@google.com Committed: https://crrev.com/f27b12ff7fd14cc13351d8eb7cf96b316e4b3d74 Cr-Commit-Position: refs/heads/master@{#330428}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M ui/webui/resources/cr_elements/v0_8/cr_checkbox/cr_checkbox.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/cr_elements/v0_8/cr_input/cr_input.js View 1 chunk +1 line, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/v0_8/cr_toggle_button/cr_toggle_button.js View 1 chunk +1 line, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/v0_8/demo_element.html View 1 chunk +6 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
michaelpg
https://codereview.chromium.org/1137873006/diff/1/ui/webui/resources/cr_elements/v0_8/demo_element.html File ui/webui/resources/cr_elements/v0_8/demo_element.html (left): https://codereview.chromium.org/1137873006/diff/1/ui/webui/resources/cr_elements/v0_8/demo_element.html#oldcode42 ui/webui/resources/cr_elements/v0_8/demo_element.html:42: <div horizontal layout> these attributes don't do anything now, ...
5 years, 7 months ago (2015-05-18 21:06:48 UTC) #1
Jeremy Klein
lgtm
5 years, 7 months ago (2015-05-18 21:09:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137873006/1
5 years, 7 months ago (2015-05-18 21:12:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 21:24:15 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:43:53 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f27b12ff7fd14cc13351d8eb7cf96b316e4b3d74
Cr-Commit-Position: refs/heads/master@{#330428}

Powered by Google App Engine
This is Rietveld 408576698