Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issue 1137873005: Create a new pulld for systemd servers. (Closed)

Created:
5 years, 7 months ago by jcgregorio
Modified:
5 years, 7 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create a new pulld for systemd servers. Note the 'd'. The next CL will create a logserverd build also, and then I should be set to create a systemd based pushable snapshot. BUG=skia: Committed: https://skia.googlesource.com/buildbot/+/14b814980bd23f656d14c315b2d110bf410946a8

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -0 lines) Patch
M push/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
A push/build_pulld_release View 1 1 chunk +17 lines, -0 lines 0 comments Download
A push/go/pulld/main.go View 1 2 1 chunk +106 lines, -0 lines 0 comments Download
A push/sys/pulld.service View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jcgregorio
5 years, 7 months ago (2015-05-18 20:40:31 UTC) #2
rmistry
LGTM https://codereview.chromium.org/1137873005/diff/20001/push/go/pulld/main.go File push/go/pulld/main.go (right): https://codereview.chromium.org/1137873005/diff/20001/push/go/pulld/main.go#newcode84 push/go/pulld/main.go:84: // If just an appname appears w/o a ...
5 years, 7 months ago (2015-05-18 20:42:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137873005/40001
5 years, 7 months ago (2015-05-18 20:50:46 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/buildbot/+/14b814980bd23f656d14c315b2d110bf410946a8
5 years, 7 months ago (2015-05-18 20:53:19 UTC) #7
jcgregorio
5 years, 7 months ago (2015-05-19 19:19:04 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/1137873005/diff/20001/push/go/pulld/main.go
File push/go/pulld/main.go (right):

https://codereview.chromium.org/1137873005/diff/20001/push/go/pulld/main.go#n...
push/go/pulld/main.go:84: // If just an appname appears w/o a packge name then
that means
On 2015/05/18 20:42:44, rmistry wrote:
> "package"

Done.

Powered by Google App Engine
This is Rietveld 408576698