Issue 1137873004: Avoid a double delete of BrowserUI on shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1137873004: Avoid a double delete of BrowserUI on shutdown. (Closed)

Created:
5 years, 7 months ago by jam

Modified:
5 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, yzshen+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Avoid a double delete of BrowserUI on shutdown. Otherwise when Browser::OnViewManagerDisconnected gets called, Browser::ui_ will get deleted twice. This is split off https://codereview.chromium.org/1139673003 BUG=484234 Committed: https://crrev.com/29eee4c6e0ec25ce65c530f3db88c1ffc8c1ae72 Cr-Commit-Position: refs/heads/master@{#330384}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	mandoline/ui/browser/browser.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137873004/1

5 years, 7 months ago (2015-05-18 16:50:20 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-18 22:41:02 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/29eee4c6e0ec25ce65c530f3db88c1ffc8c1ae72
Cr-Commit-Position: refs/heads/master@{#330384}