Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1137873002: Convert blink_gc_plugin_flags.sh to a Python script. (Closed)

Created:
5 years, 7 months ago by Nico
Modified:
5 years, 7 months ago
Reviewers:
hans
CC:
chromium-reviews, zerny-chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert blink_gc_plugin_flags.sh to a Python script. The motivation is being able to use it on Windows. No intended behavior change. https://codereview.chromium.org/1135853003/ will change blink to call the new file, then the .sh forwarding script can go away. BUG=467287 TBR=hans Committed: https://chromium.googlesource.com/chromium/src/+/f7cd57c07ed0d874c7bab225e53303f7a5b7bb6a

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : durr #

Patch Set 4 : bleh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -29 lines) Patch
A tools/clang/scripts/blink_gc_plugin_flags.py View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
M tools/clang/scripts/blink_gc_plugin_flags.sh View 1 2 1 chunk +5 lines, -29 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Nico
5 years, 7 months ago (2015-05-08 23:52:07 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137873002/40001
5 years, 7 months ago (2015-05-09 04:56:29 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) ...
5 years, 7 months ago (2015-05-09 12:15:49 UTC) #6
Nico
I'm going to TBR this so I can get the blink part in, so that ...
5 years, 7 months ago (2015-05-09 19:59:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137873002/60001
5 years, 7 months ago (2015-05-09 20:00:17 UTC) #9
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/f7cd57c07ed0d874c7bab225e53303f7a5b7bb6a Cr-Commit-Position: refs/heads/master@{#329054}
5 years, 7 months ago (2015-05-09 20:19:38 UTC) #10
Nico
Committed patchset #4 (id:60001) manually as f7cd57c07ed0d874c7bab225e53303f7a5b7bb6a (presubmit successful).
5 years, 7 months ago (2015-05-09 20:20:21 UTC) #11
hans
5 years, 7 months ago (2015-05-11 17:42:25 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698