Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: components/nacl/renderer/plugin/plugin.h

Issue 1137833003: Attempt to fix a CloseHandle crasher in the renderer process. The crash is triggered by Nacl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reverted changes to ppb_nacl_private_impl.cc Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/nacl/renderer/plugin/pnacl_translate_thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/renderer/plugin/plugin.h
diff --git a/components/nacl/renderer/plugin/plugin.h b/components/nacl/renderer/plugin/plugin.h
index 7e9a323d086f44e730dcc5811c2b73f293afc1ce..1f082225be2fb2d54f24333ae2d22f80cb0ff345 100644
--- a/components/nacl/renderer/plugin/plugin.h
+++ b/components/nacl/renderer/plugin/plugin.h
@@ -80,6 +80,8 @@ class Plugin : public pp::Instance {
// should include a time-out at which point we declare the
// nacl_ready_state to be done, and let the normal crash detection
// mechanism(s) take over.
+ // Please note that a call to this function takes over ownership of the
+ // file_info pointer.
void LoadNaClModule(PP_NaClFileInfo file_info,
bool uses_nonsfi_mode,
PP_NaClAppProcessType process_type);
@@ -89,6 +91,8 @@ class Plugin : public pp::Instance {
// Blocks until the helper module signals initialization is done.
// Does not update nacl_module_origin().
// Returns NULL or the NaClSubprocess of the new helper NaCl module.
+ // Please note that a call to this function takes over ownership of the
+ // file_info pointer.
NaClSubprocess* LoadHelperNaClModule(const std::string& helper_url,
PP_NaClFileInfo file_info,
ErrorInfo* error_info);
« no previous file with comments | « no previous file | components/nacl/renderer/plugin/pnacl_translate_thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698