Issue 1137833002: Revert of Swap the main frame in --site-per-process mode too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1137833002: Revert of Swap the main frame in --site-per-process mode too. (Closed)

Created:
5 years, 7 months ago by dcheng

Modified:
5 years, 7 months ago

Reviewers:
Charlie Reis, alexmos, nasko

CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, site-isolation-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Swap the main frame in --site-per-process mode too. (patchset #5 id:80001 of https://codereview.chromium.org/1106673002/) Reason for revert: This breaks some tests on the site isolation bots. Original issue's description: > Swap the main frame in --site-per-process mode too. > > Calling swap() is required to set up a lot of required state in Blink > for the WebRemoteFrame. Without this, bad things happen. > > BUG=475003 > > Committed: https://crrev.com/9463868c8a2d30b6a81db9fd2b61e8a5935ac347 > Cr-Commit-Position: refs/heads/master@{#329012} TBR=creis@chromium.org,nasko@chromium.org,alexmos@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=475003 Committed: https://crrev.com/42cda648aa14bf008ce1b788559e81c87cb8d5bc Cr-Commit-Position: refs/heads/master@{#329024}

Patch Set 1 #

Created: 5 years, 7 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -39 lines)			Patch
	M	content/browser/site_per_process_browsertest.cc	View		1 chunk	+0 lines, -38 lines	0 comments	Download
	M	content/renderer/render_frame_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dcheng

Created Revert of Swap the main frame in --site-per-process mode too.

5 years, 7 months ago (2015-05-08 22:21:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137833002/1

5 years, 7 months ago (2015-05-08 22:28:51 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-08 22:41:33 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/42cda648aa14bf008ce1b788559e81c87cb8d5bc
Cr-Commit-Position: refs/heads/master@{#329024}

Expand Messages | Collapse Messages