Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 113783003: Fix the Views UI example. (Closed)

Created:
7 years ago by Eran M. (Google)
Modified:
7 years ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fix the Views UI example. Otherwise the binary crashes because: [1212/100331:FATAL:input_method_auralinux.cc(54)] Check failed: LinuxInputMethodContextFactory::instance(). BUG=328052 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240648

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/views/examples/content_client/examples_browser_main_parts.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Eran M. (Google)
7 years ago (2013-12-12 10:48:36 UTC) #1
Yuki
lgtm
7 years ago (2013-12-12 12:35:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eranm@google.com/113783003/1
7 years ago (2013-12-12 13:42:44 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=40943
7 years ago (2013-12-12 13:59:02 UTC) #4
Eran M. (Google)
Ben, please take a look at this fix.
7 years ago (2013-12-12 14:00:14 UTC) #5
tfarina
OK, lgtm. If that fixes your crash. Is this filed in crbug.com/?
7 years ago (2013-12-12 15:08:03 UTC) #6
Eran M. (Google)
It is, now (Google Code was read-only for maintenance earlier). And yes, it does fix ...
7 years ago (2013-12-12 15:14:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eranm@google.com/113783003/1
7 years ago (2013-12-12 15:14:28 UTC) #8
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=40964
7 years ago (2013-12-12 15:30:36 UTC) #9
sadrul
I notice that we do the same for content-shell. LGTM
7 years ago (2013-12-13 04:11:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eranm@google.com/113783003/1
7 years ago (2013-12-13 09:51:04 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=184063
7 years ago (2013-12-13 11:17:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eranm@google.com/113783003/1
7 years ago (2013-12-13 11:20:24 UTC) #13
commit-bot: I haz the power
7 years ago (2013-12-13 14:58:17 UTC) #14
Message was sent while issue was closed. 
Change committed as 240648

Powered by Google App Engine
This is Rietveld 408576698