Source/bindings/tests/results/V8TestInterface.cpp - Issue 113783002: [POSSIBLE PERFORMANCE IMPACT] Remove UNLIKELY from bindings required arguments check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterface.cpp

Issue 113783002: [POSSIBLE PERFORMANCE IMPACT] Remove UNLIKELY from bindings required arguments check (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove FIXME Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestEventTarget.cpp ('k') | Source/bindings/tests/results/V8TestInterfaceConstructor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterface.cpp

diff --git a/Source/bindings/tests/results/V8TestInterface.cpp b/Source/bindings/tests/results/V8TestInterface.cpp

index 01227ded2eface0dd4ba0ca60e05f53f34541dad..b7aa309359df7eedbd715616d6a5baf345501257 100644

--- a/Source/bindings/tests/results/V8TestInterface.cpp

+++ b/Source/bindings/tests/results/V8TestInterface.cpp

@@ -555,7 +555,7 @@ static void implementsMethod1MethodCallback(const v8::FunctionCallbackInfo<v8::V

static void implementsMethod2Method(const v8::FunctionCallbackInfo<v8::Value>& info)

{

ExceptionState exceptionState(ExceptionState::ExecutionContext, "implementsMethod2", "TestInterface", info.Holder(), info.GetIsolate());

- if (UNLIKELY(info.Length() < 2)) {

+ if (info.Length() < 2) {

exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(2, info.Length()));

exceptionState.throwIfNeeded();

return;

@@ -621,7 +621,7 @@ static void supplementalMethod1MethodCallback(const v8::FunctionCallbackInfo<v8:

static void supplementalMethod2Method(const v8::FunctionCallbackInfo<v8::Value>& info)

{

ExceptionState exceptionState(ExceptionState::ExecutionContext, "supplementalMethod2", "TestInterface", info.Holder(), info.GetIsolate());

- if (UNLIKELY(info.Length() < 2)) {

+ if (info.Length() < 2) {

exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(2, info.Length()));

exceptionState.throwIfNeeded();

return;

@@ -677,7 +677,7 @@ static void supplementalMethod4MethodCallback(const v8::FunctionCallbackInfo<v8:

static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)

{

- if (UNLIKELY(info.Length() < 1)) {

+ if (info.Length() < 1) {

throwTypeError(ExceptionMessages::failedToExecute("Constructor", "TestInterface", ExceptionMessages::notEnoughArguments(1, info.Length())), info.GetIsolate());

return;

}