Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 1137823003: [iOS] Upstream OWNERS files (Closed)

Created:
5 years, 7 months ago by sdefresne
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Upstream OWNERS files Add a wildcard rule in ios/OWNERS to allow anyone to review *.gyp changes when only adding or removing files. BUG=None Committed: https://crrev.com/403f1df98389fb093ca67d8f588743130da5300f Cr-Commit-Position: refs/heads/master@{#329644}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove ios/chrome/app/OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/OWNERS View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (8 generated)
sdefresne
5 years, 7 months ago (2015-05-12 08:32:36 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137823003/1
5 years, 7 months ago (2015-05-12 08:32:43 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-12 08:39:34 UTC) #5
jif
lgtm
5 years, 7 months ago (2015-05-12 09:10:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137823003/1
5 years, 7 months ago (2015-05-12 09:24:24 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/62964)
5 years, 7 months ago (2015-05-12 09:32:00 UTC) #10
sdefresne
+stuartmorgan for //ios OWNERS approval
5 years, 7 months ago (2015-05-12 12:27:58 UTC) #12
stuartmorgan
https://codereview.chromium.org/1137823003/diff/1/ios/chrome/app/OWNERS File ios/chrome/app/OWNERS (right): https://codereview.chromium.org/1137823003/diff/1/ios/chrome/app/OWNERS#newcode1 ios/chrome/app/OWNERS:1: lliabraa@chromium.org This doesn't match the CL description, and also ...
5 years, 7 months ago (2015-05-12 14:45:09 UTC) #13
sdefresne
PTAL https://codereview.chromium.org/1137823003/diff/1/ios/chrome/app/OWNERS File ios/chrome/app/OWNERS (right): https://codereview.chromium.org/1137823003/diff/1/ios/chrome/app/OWNERS#newcode1 ios/chrome/app/OWNERS:1: lliabraa@chromium.org On 2015/05/12 14:45:09, stuartmorgan wrote: > This ...
5 years, 7 months ago (2015-05-12 15:18:46 UTC) #14
sdefresne
stuartmorgan: ping?
5 years, 7 months ago (2015-05-13 15:32:54 UTC) #15
sdefresne
ooops stuartmorgan is OOO rohitrao, can you have a look?
5 years, 7 months ago (2015-05-13 15:50:02 UTC) #17
rohitrao (ping after 24h)
lgtm
5 years, 7 months ago (2015-05-13 15:53:52 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137823003/20001
5 years, 7 months ago (2015-05-13 15:54:50 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-13 16:06:54 UTC) #22
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 16:08:17 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/403f1df98389fb093ca67d8f588743130da5300f
Cr-Commit-Position: refs/heads/master@{#329644}

Powered by Google App Engine
This is Rietveld 408576698