|
|
Description[iOS] Upstream OWNERS files
Add a wildcard rule in ios/OWNERS to allow anyone to review *.gyp changes
when only adding or removing files.
BUG=None
Committed: https://crrev.com/403f1df98389fb093ca67d8f588743130da5300f
Cr-Commit-Position: refs/heads/master@{#329644}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove ios/chrome/app/OWNERS #
Messages
Total messages: 23 (8 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137823003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137823003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
sdefresne@chromium.org changed reviewers: + stuartmorgan@chromium.org
+stuartmorgan for //ios OWNERS approval
https://codereview.chromium.org/1137823003/diff/1/ios/chrome/app/OWNERS File ios/chrome/app/OWNERS (right): https://codereview.chromium.org/1137823003/diff/1/ios/chrome/app/OWNERS#newcode1 ios/chrome/app/OWNERS:1: lliabraa@chromium.org This doesn't match the CL description, and also isn't a change we want to make.
PTAL https://codereview.chromium.org/1137823003/diff/1/ios/chrome/app/OWNERS File ios/chrome/app/OWNERS (right): https://codereview.chromium.org/1137823003/diff/1/ios/chrome/app/OWNERS#newcode1 ios/chrome/app/OWNERS:1: lliabraa@chromium.org On 2015/05/12 14:45:09, stuartmorgan wrote: > This doesn't match the CL description, and also isn't a change we want to make. You're right, removed (and will remove the file downstream).
stuartmorgan: ping?
sdefresne@chromium.org changed reviewers: + rohitrao@chromium.org - stuartmorgan@chromium.org
ooops stuartmorgan is OOO rohitrao, can you have a look?
lgtm
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org Link to the patchset: https://codereview.chromium.org/1137823003/#ps20001 (title: "Remove ios/chrome/app/OWNERS")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137823003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/403f1df98389fb093ca67d8f588743130da5300f Cr-Commit-Position: refs/heads/master@{#329644} |