Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: content/renderer/gpu/render_widget_compositor.cc

Issue 1137823002: Pass collected frame timing events to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Send finishTime as well for Render events. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/render_widget_compositor.cc
diff --git a/content/renderer/gpu/render_widget_compositor.cc b/content/renderer/gpu/render_widget_compositor.cc
index 54ece1b2e82276650fbfede4b88790953b1d2e09..3a33b96d01f100cb8bb2f4e80bab2931dc2c6f0c 100644
--- a/content/renderer/gpu/render_widget_compositor.cc
+++ b/content/renderer/gpu/render_widget_compositor.cc
@@ -884,6 +884,44 @@ void RenderWidgetCompositor::ApplyViewportDeltas(
top_controls_delta);
}
+static std::tuple<int, double, double> CompositeTimingEventToDouble(
vmpstr 2015/05/12 23:48:26 I don't think you can use a tuple unless we have f
MikeB 2015/05/21 21:53:08 Done.
+ const cc::FrameTimingTracker::CompositeTimingEvent& event) {
+ return std::make_tuple(event.frame_id,
+ (event.timestamp - base::TimeTicks()).InSecondsF(),
+ 0);
+}
+
+void RenderWidgetCompositor::RecordCompositeTimings(
+ cc::FrameTimingTracker::CompositeTimingSet* composites) {
+ for (const auto& record : *composites ) {
vmpstr 2015/05/12 23:48:26 Can you give names (variables) to record.first and
MikeB 2015/05/21 21:53:08 Done.
+ std::vector<std::tuple<int, double, double>>
+ compositeTiming(record.second.size());
+ std::transform(record.second.begin(), record.second.end(),
+ compositeTiming.begin(), CompositeTimingEventToDouble);
+ widget_->webwidget()->recordFrameTimingEvent(
+ blink::WebWidget::CompositeEvent, record.first, compositeTiming);
+ }
+}
+
+static std::tuple<int, double, double> MainFrameTimingEventToDouble(
+ const cc::FrameTimingTracker::MainFrameTimingEvent& event) {
+ return std::make_tuple(event.frame_id,
+ (event.timestamp - base::TimeTicks()).InSecondsF(),
+ (event.end_time - base::TimeTicks()).InSecondsF());
+}
+
+void RenderWidgetCompositor::RecordRenderTimings(
+ cc::FrameTimingTracker::MainFrameTimingSet* renders) {
+ for (const auto& record : *renders ) {
+ std::vector<std::tuple<int, double, double>>
+ renderTiming(record.second.size());
+ std::transform(record.second.begin(), record.second.end(),
+ renderTiming.begin(), MainFrameTimingEventToDouble);
+ widget_->webwidget()->recordFrameTimingEvent(
+ blink::WebWidget::RenderEvent, record.first, renderTiming);
+ }
+}
+
void RenderWidgetCompositor::RequestNewOutputSurface() {
// If the host is closing, then no more compositing is possible. This
// prevents shutdown races between handling the close message and

Powered by Google App Engine
This is Rietveld 408576698