Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1137813003: Rename "file_system_provider" to "file_system_provider_capabilities". (Closed)

Created:
5 years, 7 months ago by mtomasz
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename "file_system_provider" to "file_system_provider_capabilities". This CL renames the section in the manifest, so it's more meaningful. TEST=Refactoring only. BUG=474146 Committed: https://crrev.com/aa0c3c9c6ac682fccf19ef494e3f8a7f642807bc Cr-Commit-Position: refs/heads/master@{#329316}

Patch Set 1 #

Patch Set 2 : Updated tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -183 lines) Patch
M chrome/browser/chromeos/file_system_provider/registry.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/_manifest_features.json View 1 chunk +4 lines, -6 lines 0 comments Download
D chrome/common/extensions/api/file_system_provider/file_system_provider_handler.h View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/common/extensions/api/file_system_provider/file_system_provider_handler.cc View 1 chunk +0 lines, -88 lines 0 comments Download
A + chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.cc View 3 chunks +14 lines, -11 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/configure/manifest.json View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/mount/manifest.json View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_constants.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mtomasz
@kalman: PTAL. It's a little verbose, but I much better than previous "file_system_provider" which could ...
5 years, 7 months ago (2015-05-11 02:24:06 UTC) #2
not at google - send to devlin
lgtm
5 years, 7 months ago (2015-05-11 17:59:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137813003/20001
5 years, 7 months ago (2015-05-12 00:26:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 02:11:05 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 02:12:55 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aa0c3c9c6ac682fccf19ef494e3f8a7f642807bc
Cr-Commit-Position: refs/heads/master@{#329316}

Powered by Google App Engine
This is Rietveld 408576698