content/public/common/service_registry.h - Issue 1137803005: Add a ServiceRegistry::ConnectToRemoteService that takes an InterfaceRequest<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/service_registry.h

Issue 1137803005: Add a ServiceRegistry::ConnectToRemoteService that takes an InterfaceRequest<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@utility-process-report-js-memory

Patch Set: Rebase and update comment. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/task_manager/child_process_resource_provider.cc ('K') | « chrome/browser/task_manager/child_process_resource_provider.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/common/service_registry.h

diff --git a/content/public/common/service_registry.h b/content/public/common/service_registry.h

index 2d65cf9ee93c7687d229cf162e03501785d6fb2f..ab9c59d53be4f2592b034373b60e72763d421020 100644

--- a/content/public/common/service_registry.h

+++ b/content/public/common/service_registry.h

@@ -57,6 +57,10 @@ class CONTENT_EXPORT ServiceRegistry {

ConnectToRemoteService(Interface::Name_,

Sam McNally 2015/05/20 02:53:13 This can just forward to the InterfaceRequest over

Anand Mistry (off Chromium) 2015/05/20 03:14:59 Done.

mojo::GetProxy(ptr).PassMessagePipe());

}

+ template <typename Interface>

+ void ConnectToRemoteService(mojo::InterfaceRequest<Interface> ptr) {

+ ConnectToRemoteService(Interface::Name_, ptr.PassMessagePipe());

+ }

virtual void ConnectToRemoteService(const base::StringPiece& name,

mojo::ScopedMessagePipeHandle handle) = 0;

« chrome/browser/task_manager/child_process_resource_provider.cc ('K') | « chrome/browser/task_manager/child_process_resource_provider.cc ('k') | no next file » | no next file with comments »