Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1137803005: Add a ServiceRegistry::ConnectToRemoteService that takes an InterfaceRequest<>. (Closed)

Created:
5 years, 7 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 7 months ago
Reviewers:
Sam McNally, jam
CC:
chromium-reviews, darin-cc_chromium.org, jam, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@utility-process-report-js-memory
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a ServiceRegistry::ConnectToRemoteService that takes an InterfaceRequest<>. And change the task manager to use it. Committed: https://crrev.com/56de0e5c5268dd9f4266c32f4340c88e31bc8a7a Cr-Commit-Position: refs/heads/master@{#330881}

Patch Set 1 #

Patch Set 2 : Name change. #

Patch Set 3 : Rebase and update comment. #

Total comments: 4

Patch Set 4 : Review comment. #

Patch Set 5 : Rebase #

Total comments: 2

Patch Set 6 : Remove Pass(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -36 lines) Patch
M chrome/browser/process_resource_usage.h View 1 2 3 4 1 chunk +25 lines, -7 lines 0 comments Download
M chrome/browser/task_manager/child_process_resource_provider.cc View 1 2 3 4 3 chunks +14 lines, -27 lines 0 comments Download
M content/public/common/service_registry.h View 1 2 3 4 5 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Anand Mistry (off Chromium)
5 years, 7 months ago (2015-05-20 01:38:44 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137803005/40001
5 years, 7 months ago (2015-05-20 01:52:33 UTC) #4
Sam McNally
https://codereview.chromium.org/1137803005/diff/40001/chrome/browser/task_manager/child_process_resource_provider.cc File chrome/browser/task_manager/child_process_resource_provider.cc (right): https://codereview.chromium.org/1137803005/diff/40001/chrome/browser/task_manager/child_process_resource_provider.cc#newcode128 chrome/browser/task_manager/child_process_resource_provider.cc:128: resource_usage_.reset(new ProcessResourceUsage(service.Pass())); This change will cause ProcessResourceUsages to be ...
5 years, 7 months ago (2015-05-20 02:53:13 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-20 03:06:03 UTC) #7
Anand Mistry (off Chromium)
https://codereview.chromium.org/1137803005/diff/40001/chrome/browser/task_manager/child_process_resource_provider.cc File chrome/browser/task_manager/child_process_resource_provider.cc (right): https://codereview.chromium.org/1137803005/diff/40001/chrome/browser/task_manager/child_process_resource_provider.cc#newcode128 chrome/browser/task_manager/child_process_resource_provider.cc:128: resource_usage_.reset(new ProcessResourceUsage(service.Pass())); On 2015/05/20 02:53:12, Sam McNally wrote: > ...
5 years, 7 months ago (2015-05-20 03:14:59 UTC) #8
jam
lgtm
5 years, 7 months ago (2015-05-20 15:18:06 UTC) #9
Sam McNally
LGTM https://codereview.chromium.org/1137803005/diff/80001/content/public/common/service_registry.h File content/public/common/service_registry.h (right): https://codereview.chromium.org/1137803005/diff/80001/content/public/common/service_registry.h#newcode57 content/public/common/service_registry.h:57: ConnectToRemoteService(mojo::GetProxy(ptr).Pass()); Remove the .Pass(). mojo::GetProxy() already returns an ...
5 years, 7 months ago (2015-05-21 00:00:05 UTC) #10
Anand Mistry (off Chromium)
https://codereview.chromium.org/1137803005/diff/80001/content/public/common/service_registry.h File content/public/common/service_registry.h (right): https://codereview.chromium.org/1137803005/diff/80001/content/public/common/service_registry.h#newcode57 content/public/common/service_registry.h:57: ConnectToRemoteService(mojo::GetProxy(ptr).Pass()); On 2015/05/21 00:00:05, Sam McNally wrote: > Remove ...
5 years, 7 months ago (2015-05-21 00:12:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137803005/100001
5 years, 7 months ago (2015-05-21 00:13:35 UTC) #14
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 7 months ago (2015-05-21 04:31:52 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 04:32:46 UTC) #16
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/56de0e5c5268dd9f4266c32f4340c88e31bc8a7a
Cr-Commit-Position: refs/heads/master@{#330881}

Powered by Google App Engine
This is Rietveld 408576698