test/NaCl/X86/dynamic-stack-alloc2.ll - Issue 1137803004: Add support for using MI bundles as bundle-locked groups on x86

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/NaCl/X86/dynamic-stack-alloc2.ll

Issue 1137803004: Add support for using MI bundles as bundle-locked groups on x86 (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Patch Set: add test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 ; RUN: llc -mtriple=x86_64-nacl %s -o - \| FileCheck %s

	2

	3 ; CHECK-LABEL: @foo
	jvoung (off chromium) 2015/05/12 23:53:05 nit: seems better to put this by the function (at nit: seems better to put this by the function (at least after the "target datalayout ...; target triple ..." stuff in case more functions are added). Derek Schuff 2015/05/13 00:44:50 Done. Show quoted text On 2015/05/12 23:53:05, jvoung wrote: > nit: seems better to put this by the function (at least after the "target > datalayout ...; target triple ..." stuff in case more functions are added). Done.
	4 ; CHECK: .bundle_lock

	5 ; CHECK: leal -16({{.*}}), %esp

	6 ; CHECK: addq %r15, %rsp

	7 ; CHECK: .bundle_unlock

	8

	9 target datalayout = "e-p:32:32-i64:64-n32"

	10 target triple = "le32-unknown-nacl"

	11

	12 define hidden void @foo(i32 %agg.result, <16 x i8> %v) {
	jvoung (off chromium) 2015/05/12 23:53:05 The parameters are unused -- is it important for t The parameters are unused -- is it important for them to be around? Derek Schuff 2015/05/13 00:44:50 no, removed Show quoted text On 2015/05/12 23:53:05, jvoung wrote: > The parameters are unused -- is it important for them to be around? no, removed
	13 entry:

	14 br label %bb1
	jvoung (off chromium) 2015/05/12 23:53:05 Is it required that the alloca not be in the entry Is it required that the alloca not be in the entry block, or can this be simplified more? Otherwise, document why? Derek Schuff 2015/05/13 00:44:50 yes it is required, comment added. Show quoted text On 2015/05/12 23:53:05, jvoung wrote: > Is it required that the alloca not be in the entry block, or can this be > simplified more? Otherwise, document why? yes it is required, comment added.
	15

	16 bb1:

	17 %0 = alloca i8, i32 16, align 16

	18 %.asint = ptrtoint i8* %0 to i32

	19 %gep109 = add i32 %.asint, 0
	jvoung (off chromium) 2015/05/12 23:53:05 Would it be more resilient to optimization have ad Would it be more resilient to optimization have add non-zero? Derek Schuff 2015/05/13 00:44:50 actually the add isn't necessary at all. Show quoted text On 2015/05/12 23:53:05, jvoung wrote: > Would it be more resilient to optimization have add non-zero? actually the add isn't necessary at all.
	20 %gep109.asptr = inttoptr i32 %gep109 to i8*

	21 %1 = load i8, i8* %gep109.asptr, align 1

	22 %conv.i = sext i8 %1 to i32

	23 %call5 = call i32 @bar(i32 undef, i32 %conv.i)

	24 unreachable

	25 }

	26

	27

	28 declare hidden i32 @bar(i32, i32)

	29

	30
	jvoung (off chromium) 2015/05/12 23:53:05 extra space extra space Derek Schuff 2015/05/13 00:44:50 Done. Show quoted text On 2015/05/12 23:53:05, jvoung wrote: > extra space Done.
	31

OLD	NEW

« lib/Target/X86/X86NaClRewritePass.cpp ('K') | « lib/Target/X86/X86NaClRewritePass.cpp ('k') | no next file » | no next file with comments »