Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1137753006: sdch: add Sdch3.AdvertisedWithSecureScheme histogram (Closed)

Created:
5 years, 7 months ago by Elly Fong-Jones
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sdch: add Sdch3.AdvertisedWithSecureScheme histogram This histogram tracks how frequently SDCH is advertised over a secure scheme. BUG=488086 Committed: https://crrev.com/d540b4c265392b42bbf4f713c08775eb3f397159 Cr-Commit-Position: refs/heads/master@{#329921}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add more detail for histogram #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M net/base/sdch_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Elly Fong-Jones
rdsmith, asvitkine: PTAL? :)
5 years, 7 months ago (2015-05-14 15:46:13 UTC) #2
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/1137753006/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1137753006/diff/1/tools/metrics/histograms/histograms.xml#newcode35252 tools/metrics/histograms/histograms.xml:35252: + Whether an SDCH dictionary was advertised over ...
5 years, 7 months ago (2015-05-14 15:48:03 UTC) #3
Randy Smith (Not in Mondays)
lgtm
5 years, 7 months ago (2015-05-14 19:37:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137753006/20001
5 years, 7 months ago (2015-05-14 19:39:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 20:35:40 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 20:36:28 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d540b4c265392b42bbf4f713c08775eb3f397159
Cr-Commit-Position: refs/heads/master@{#329921}

Powered by Google App Engine
This is Rietveld 408576698