Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1137753005: Updating extension hosting docs (Closed)

Created:
5 years, 7 months ago by mkearney1
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating extension hosting docs NOTRY=true Committed: https://crrev.com/c948e63d49492934bcddfc5605fc208916d03db7 Cr-Commit-Position: refs/heads/master@{#329681}

Patch Set 1 #

Patch Set 2 : more changes #

Patch Set 3 : changes to extensions policy #

Total comments: 6

Patch Set 4 : Ben's fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -61 lines) Patch
M chrome/common/extensions/docs/templates/articles/external_extensions.html View 1 2 3 6 chunks +100 lines, -50 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/hosting.html View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/single_purpose.html View 1 2 3 7 chunks +20 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mkearney1
Ben, this one is ready for review. I've tested the docs in the local server ...
5 years, 7 months ago (2015-05-13 18:18:49 UTC) #2
not at google - send to devlin
lgtm https://codereview.chromium.org/1137753005/diff/40001/chrome/common/extensions/docs/templates/articles/external_extensions.html File chrome/common/extensions/docs/templates/articles/external_extensions.html (right): https://codereview.chromium.org/1137753005/diff/40001/chrome/common/extensions/docs/templates/articles/external_extensions.html#newcode6 chrome/common/extensions/docs/templates/articles/external_extensions.html:6: <a href="https://developer.chrome.com/webstore/inline_installation">inline installation</a>, For all of these links, ...
5 years, 7 months ago (2015-05-13 18:23:27 UTC) #3
not at google - send to devlin
(but fix comments before submitting)
5 years, 7 months ago (2015-05-13 18:23:37 UTC) #4
mkearney1
Review comments actioned. https://codereview.chromium.org/1137753005/diff/40001/chrome/common/extensions/docs/templates/articles/external_extensions.html File chrome/common/extensions/docs/templates/articles/external_extensions.html (right): https://codereview.chromium.org/1137753005/diff/40001/chrome/common/extensions/docs/templates/articles/external_extensions.html#newcode6 chrome/common/extensions/docs/templates/articles/external_extensions.html:6: <a href="https://developer.chrome.com/webstore/inline_installation">inline installation</a>, On 2015/05/13 18:23:27, ...
5 years, 7 months ago (2015-05-13 18:36:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137753005/60001
5 years, 7 months ago (2015-05-13 18:37:46 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-13 18:43:41 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 18:44:35 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c948e63d49492934bcddfc5605fc208916d03db7
Cr-Commit-Position: refs/heads/master@{#329681}

Powered by Google App Engine
This is Rietveld 408576698