Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1137753002:
[Chromoting] Remove check for out/Release dir in build-webapp.py (Closed)
Description[Chromoting] Remove check for out/Release dir in build-webapp.py
This check is not valid for GN release/prod builds.
BUG=
Committed: https://crrev.com/5680b241063cc434af2609809b7a17b5e39a55b4
Cr-Commit-Position: refs/heads/master@{#329174}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 21 (9 generated)
garykac@chromium.org changed reviewers: + joedow@chromium.org
lgtm https://codereview.chromium.org/1137753002/diff/1/remoting/webapp/build-webap... File remoting/webapp/build-webapp.py (left): https://codereview.chromium.org/1137753002/diff/1/remoting/webapp/build-webap... remoting/webapp/build-webapp.py:251: raise Exception('Prod builds must be placed in the out/Release folder') I think we can remove this check but we just need to be careful when pushing store builds, especially if it comes from a random GN bin directory :)
The CQ bit was checked by garykac@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137753002/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
jamiewalch@chromium.org changed reviewers: + jamiewalch@chromium.org
lgtm
The CQ bit was checked by garykac@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137753002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by garykac@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137753002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by garykac@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137753002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5680b241063cc434af2609809b7a17b5e39a55b4 Cr-Commit-Position: refs/heads/master@{#329174} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
