Object.observe: Use [[DefineOwnProperty]] to create properties of changeRecord

src/object-observe.js

Index: src/object-observe.js
diff --git a/src/object-observe.js b/src/object-observe.js
index 1b0a491a03215765b07ea6a9efa3a0988871daa0..26c7858d9dd7e5952d092f4edc194491a6bb0608 100644
--- a/src/object-observe.js
+++ b/src/object-observe.js
@@ -27,9 +27,6 @@
 
 "use strict";
 
-var InternalObjectIsFrozen = $Object.isFrozen;
-var InternalObjectFreeze = $Object.freeze;
-
 var observationState = %GetObservationState();
 if (IS_UNDEFINED(observationState.observerInfoMap)) {
   observationState.observerInfoMap = %CreateObjectHashTable();
@@ -74,7 +71,7 @@ function ObjectObserve(object, callback) {
     throw MakeTypeError("observe_non_object", ["observe"]);
   if (!IS_SPEC_FUNCTION(callback))
     throw MakeTypeError("observe_non_function", ["observe"]);
-  if (InternalObjectIsFrozen(callback))
+  if (ObjectIsFrozen(callback))
     throw MakeTypeError("observe_callback_frozen");
 
   if (!observerInfoMap.has(callback)) {
@@ -134,7 +131,7 @@ function NotifyChange(type, object, name, oldValue) {
   var changeRecord = (arguments.length < 4) ?
       { type: type, object: object, name: name } :
       { type: type, object: object, name: name, oldValue: oldValue };
-  InternalObjectFreeze(changeRecord);
+  ObjectFreeze(changeRecord);
   EnqueueChangeRecord(changeRecord, objectInfo.changeObservers);
 }
 
@@ -164,9 +161,13 @@ function ObjectNotifierNotify(changeRecord) {
   for (var prop in changeRecord) {
     if (prop === 'object')
       continue;
-    newRecord[prop] = changeRecord[prop];
+
+    ObjectDefineProperty(newRecord, prop, {

[rossberg, 2012/11/15 14:16:34]

You should be able to use

%DefineOrRedefineDataProperty(newRecord, prop, changeRecord[prop], READ_ONLY +
DONT_DELETE)

which has less overhead.

[rafaelw, 2012/11/15 17:15:43]

done.

On 2012/11/15 14:16:34, rossberg wrote:

+      value: changeRecord[prop],
+      enumerable: true
+    });
   }
-  InternalObjectFreeze(newRecord);
+  ObjectFreeze(newRecord);
 
   EnqueueChangeRecord(newRecord, objectInfo.changeObservers);
 }
@@ -175,7 +176,7 @@ function ObjectGetNotifier(object) {
   if (!IS_SPEC_OBJECT(object))
     throw MakeTypeError("observe_non_object", ["getNotifier"]);
 
-  if (InternalObjectIsFrozen(object))
+  if (ObjectIsFrozen(object))
     return null;
 
   var objectInfo = objectInfoMap.get(object);