Object.observe: Use [[DefineOwnProperty]] to create properties of changeRecord

src/object-observe.js

Index: src/object-observe.js
diff --git a/src/object-observe.js b/src/object-observe.js
index 1b0a491a03215765b07ea6a9efa3a0988871daa0..c4c2009aa312a297fb8d112695ae1ef9b6f2214e 100644
--- a/src/object-observe.js
+++ b/src/object-observe.js
@@ -29,6 +29,7 @@
 
 var InternalObjectIsFrozen = $Object.isFrozen;
 var InternalObjectFreeze = $Object.freeze;
+var InternalObjectDefineProperty = $Object.defineProperty;

[adamk, 2012/11/14 22:32:24]

Not sure these are worth it, at least not until we actually segregate the
globals of these different builtins. Might as well just call
ObjectDefineProperty(), ObjectIsFrozen(), and ObjectFreeze() (all of which exist
and correspond to the proper methods on Object).

[rafaelw, 2012/11/14 22:40:56]

Removed.

On 2012/11/14 22:32:24, adamk wrote:

 
 var observationState = %GetObservationState();
 if (IS_UNDEFINED(observationState.observerInfoMap)) {
@@ -164,7 +165,11 @@ function ObjectNotifierNotify(changeRecord) {
   for (var prop in changeRecord) {
     if (prop === 'object')
       continue;
-    newRecord[prop] = changeRecord[prop];
+
+    InternalObjectDefineProperty(newRecord, prop, {
+      value: changeRecord[prop],
+      enumerable: true
+    });
   }
   InternalObjectFreeze(newRecord);