Object.observe: Use [[DefineOwnProperty]] to create properties of changeRecord

src/object-observe.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 11 matching lines @@
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 "use strict";
 
 var InternalObjectIsFrozen = $Object.isFrozen;
 var InternalObjectFreeze = $Object.freeze;
+var InternalObjectDefineProperty = $Object.defineProperty;

[adamk, 2012/11/14 22:32:24]

Not sure these are worth it, at least not until we actually segregate the
globals of these different builtins. Might as well just call
ObjectDefineProperty(), ObjectIsFrozen(), and ObjectFreeze() (all of which exist
and correspond to the proper methods on Object).

[rafaelw, 2012/11/14 22:40:56]

Removed.

On 2012/11/14 22:32:24, adamk wrote:

 
 var observationState = %GetObservationState();
 if (IS_UNDEFINED(observationState.observerInfoMap)) {
   observationState.observerInfoMap = %CreateObjectHashTable();
   observationState.objectInfoMap = %CreateObjectHashTable();
   observationState.notifierTargetMap = %CreateObjectHashTable();
   observationState.pendingObservers = new InternalArray;
   observationState.observerPriority = 0;
 }
 
@@ skipping 115 matching lines @@
 
   if (!objectInfo.changeObservers.length)
     return;
 
   var newRecord = {
     object: target
   };
   for (var prop in changeRecord) {
     if (prop === 'object')
       continue;
-    newRecord[prop] = changeRecord[prop];
+
+    InternalObjectDefineProperty(newRecord, prop, {
+      value: changeRecord[prop],
+      enumerable: true
+    });
   }
   InternalObjectFreeze(newRecord);
 
   EnqueueChangeRecord(newRecord, objectInfo.changeObservers);
 }
 
 function ObjectGetNotifier(object) {
   if (!IS_SPEC_OBJECT(object))
     throw MakeTypeError("observe_non_object", ["getNotifier"]);
 
@@ skipping 56 matching lines @@
     "getNotifier", ObjectGetNotifier,
     "observe", ObjectObserve,
     "unobserve", ObjectUnobserve
   ));
   InstallFunctions(notifierPrototype, DONT_ENUM, $Array(
     "notify", ObjectNotifierNotify
   ));
 }
 
 SetupObjectObserve();