Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: runtime/vm/compiler.cc

Issue 11377164: Never compile a redirecting factory (issue 6697). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/compiler.h" 5 #include "vm/compiler.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 8
9 #include "vm/ast_printer.h" 9 #include "vm/ast_printer.h"
10 #include "vm/code_generator.h" 10 #include "vm/code_generator.h"
(...skipping 518 matching lines...) Expand 10 before | Expand all | Expand 10 after
529 } 529 }
530 530
531 531
532 RawError* Compiler::CompileAllFunctions(const Class& cls) { 532 RawError* Compiler::CompileAllFunctions(const Class& cls) {
533 Error& error = Error::Handle(); 533 Error& error = Error::Handle();
534 Array& functions = Array::Handle(cls.functions()); 534 Array& functions = Array::Handle(cls.functions());
535 Function& func = Function::Handle(); 535 Function& func = Function::Handle();
536 for (int i = 0; i < functions.Length(); i++) { 536 for (int i = 0; i < functions.Length(); i++) {
537 func ^= functions.At(i); 537 func ^= functions.At(i);
538 ASSERT(!func.IsNull()); 538 ASSERT(!func.IsNull());
539 if (!func.HasCode() && !func.is_abstract()) { 539 if (!func.HasCode() &&
540 !func.is_abstract() &&
541 !func.IsRedirectingFactory()) {
540 error = CompileFunction(func); 542 error = CompileFunction(func);
541 if (!error.IsNull()) { 543 if (!error.IsNull()) {
542 return error.raw(); 544 return error.raw();
543 } 545 }
544 } 546 }
545 } 547 }
546 return error.raw(); 548 return error.raw();
547 } 549 }
548 550
549 551
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
605 result = isolate->object_store()->sticky_error(); 607 result = isolate->object_store()->sticky_error();
606 isolate->object_store()->clear_sticky_error(); 608 isolate->object_store()->clear_sticky_error();
607 isolate->set_long_jump_base(base); 609 isolate->set_long_jump_base(base);
608 return result.raw(); 610 return result.raw();
609 } 611 }
610 UNREACHABLE(); 612 UNREACHABLE();
611 return Object::null(); 613 return Object::null();
612 } 614 }
613 615
614 } // namespace dart 616 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698