src/api.cc - Issue 11377158: Fire 'stack' getter of error objects after GC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 11377158: Fire 'stack' getter of error objects after GC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: use hidden properties to mark oneshot getter Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index a6619f137212dc49322488ced857d22ee828d970..22fad2a89d2c26f428ec0aa5b0b0e776ed7b590e 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -1820,7 +1820,7 @@ v8::Local<Value> v8::TryCatch::StackTrace() const {

if (!raw_obj->IsJSObject()) return v8::Local<Value>();

i::HandleScope scope(isolate_);

i::Handle<i::JSObject> obj(i::JSObject::cast(raw_obj), isolate_);

- i::Handle<i::String> name = isolate_->factory()->LookupAsciiSymbol("stack");

+ i::Handle<i::String> name = isolate_->factory()->stack_symbol();

if (!obj->HasProperty(*name)) return v8::Local<Value>();

i::Handle<i::Object> value = i::GetProperty(obj, name);

if (value.is_null()) return v8::Local<Value>();

« no previous file with comments | « no previous file | src/heap.h » ('j') | src/messages.js » ('J')