Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Side by Side Diff: test/cctest/test-decls.cc

Issue 11377158: Fire 'stack' getter of error objects after GC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2007-2008 the V8 project authors. All rights reserved. 1 // Copyright 2007-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 if (!value.IsEmpty()) { 154 if (!value.IsEmpty()) {
155 CHECK_EQ(value, result); 155 CHECK_EQ(value, result);
156 } 156 }
157 } else { 157 } else {
158 CHECK(expectations == EXPECT_EXCEPTION); 158 CHECK(expectations == EXPECT_EXCEPTION);
159 CHECK(catcher.HasCaught()); 159 CHECK(catcher.HasCaught());
160 if (!value.IsEmpty()) { 160 if (!value.IsEmpty()) {
161 CHECK_EQ(value, catcher.Exception()); 161 CHECK_EQ(value, catcher.Exception());
162 } 162 }
163 } 163 }
164 HEAP->CollectAllAvailableGarbage(); // Clean slate for the next test.
164 } 165 }
165 166
166 167
167 v8::Handle<Value> DeclarationContext::HandleGet(Local<String> key, 168 v8::Handle<Value> DeclarationContext::HandleGet(Local<String> key,
168 const AccessorInfo& info) { 169 const AccessorInfo& info) {
169 DeclarationContext* context = GetInstance(info); 170 DeclarationContext* context = GetInstance(info);
170 context->get_count_++; 171 context->get_count_++;
171 return context->Get(key); 172 return context->Get(key);
172 } 173 }
173 174
(...skipping 724 matching lines...) Expand 10 before | Expand all | Expand 10 after
898 EXPECT_ERROR); 899 EXPECT_ERROR);
899 } 900 }
900 901
901 { SimpleContext context; 902 { SimpleContext context;
902 context.Check("const x = 1; x", 903 context.Check("const x = 1; x",
903 EXPECT_RESULT, Number::New(1)); 904 EXPECT_RESULT, Number::New(1));
904 context.Check("function x() { return 2 }; x()", 905 context.Check("function x() { return 2 }; x()",
905 EXPECT_ERROR); 906 EXPECT_ERROR);
906 } 907 }
907 } 908 }
OLDNEW
« src/heap.cc ('K') | « src/messages.js ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698