Object.observe: Add test case covering most special cases.

Object.observe: Add test case covering most special cases.

Things not working yet are currently blacklisted in the test (see TODOs).

R=verwaest@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=13016

[rafaelw, 2012-11-20 05:11:07]

mostly lg

https://codereview.chromium.org/11377157/diff/2002/test/mjsunit/harmony/objec...
File test/mjsunit/harmony/object-observe.js (right):

https://codereview.chromium.org/11377157/diff/2002/test/mjsunit/harmony/objec...
test/mjsunit/harmony/object-observe.js:59: print(i,
JSON.stringify(this.records[i]), JSON.stringify(recs[i]));
did you intend to leave this in?

https://codereview.chromium.org/11377157/diff/2002/test/mjsunit/harmony/objec...
test/mjsunit/harmony/object-observe.js:428:
Object.deliverChangeRecords(this.callback);
In what case will this generate a changeRecord?

https://codereview.chromium.org/11377157/diff/2002/test/mjsunit/harmony/objec...
test/mjsunit/harmony/object-observe.js:433:
Object.deliverChangeRecords(this.callback);
same question?

https://codereview.chromium.org/11377157/diff/2002/test/mjsunit/harmony/objec...
test/mjsunit/harmony/object-observe.js:437: var x =
Object.defineProperty(this.target, k, desc);
how much of direct proxies are implemented? i would have thought you'd need t
trap set as well as defineProperty.

https://codereview.chromium.org/11377157/diff/2002/test/mjsunit/harmony/objec...
test/mjsunit/harmony/object-observe.js:474: new ArrayBuffer(10), new
Int32Array(5),
new Map, new Set, new WeakMap?

[rossberg, 2012-11-20 10:34:27]

https://codereview.chromium.org/11377157/diff/2002/test/mjsunit/harmony/objec...
File test/mjsunit/harmony/object-observe.js (right):

https://codereview.chromium.org/11377157/diff/2002/test/mjsunit/harmony/objec...
test/mjsunit/harmony/object-observe.js:59: print(i,
JSON.stringify(this.records[i]), JSON.stringify(recs[i]));
On 2012/11/20 05:11:07, rafaelw wrote:
> did you intend to leave this in?

Yes. I was taking this in and out so many times in the past while debugging
tests, that I decided to just leave it in this time. Doesn't harm.

https://codereview.chromium.org/11377157/diff/2002/test/mjsunit/harmony/objec...
test/mjsunit/harmony/object-observe.js:428:
Object.deliverChangeRecords(this.callback);
On 2012/11/20 05:11:07, rafaelw wrote:
> In what case will this generate a changeRecord?

You are right, dumb copy & paste. Shouldn't be needed.

https://codereview.chromium.org/11377157/diff/2002/test/mjsunit/harmony/objec...
test/mjsunit/harmony/object-observe.js:433:
Object.deliverChangeRecords(this.callback);
On 2012/11/20 05:11:07, rafaelw wrote:
> same question?

Ditto.

https://codereview.chromium.org/11377157/diff/2002/test/mjsunit/harmony/objec...
test/mjsunit/harmony/object-observe.js:437: var x =
Object.defineProperty(this.target, k, desc);
On 2012/11/20 05:11:07, rafaelw wrote:
> how much of direct proxies are implemented? i would have thought you'd need t
> trap set as well as defineProperty.

'set' is a derived trap in the old semantics, which means that if you don't
provide it, a default is constructed from other traps (see DerivedSetTrap in
proxy.js).

https://codereview.chromium.org/11377157/diff/2002/test/mjsunit/harmony/objec...
test/mjsunit/harmony/object-observe.js:474: new ArrayBuffer(10), new
Int32Array(5),
On 2012/11/20 05:11:07, rafaelw wrote:
> new Map, new Set, new WeakMap?

Done.

[rafaelw, 2012-11-20 14:15:23]

lgtm

[Toon Verwaest, 2012-11-21 08:37:09]

lgtm