Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 11377122: cc: Visualize non-occluding rects in composited layers. (Closed)

Created:
8 years, 1 month ago by danakj
Modified:
8 years, 1 month ago
Reviewers:
jamesr, jam, enne (OOO)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam
Visibility:
Public.

Description

cc: Visualize non-occluding rects in composited layers. Adds a new flag to show non-occluding rects. When this flag is on, then for any layer which could have been occluding, but isn't we show a rectangle on the screen. This means for layers that have 3d transforms and would never be occluding, we don't draw rectangles. For axis aligned rectangles with opacity < 1, we don't draw rectangles. But when a layer has opacity=1, is axis aligned, but its contents are not considered opaque, then we draw a rect to warn the user that this area could have been occluding if only its contents had been considered opaque. New command-line flag: --show-nonoccluding-rects R=jamesr,enne BUG=160643 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167816

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -9 lines) Patch
M cc/debug_rect_history.h View 3 chunks +6 lines, -2 lines 0 comments Download
M cc/debug_rect_history.cc View 3 chunks +10 lines, -1 line 0 comments Download
M cc/heads_up_display_layer_impl.cc View 1 chunk +6 lines, -1 line 0 comments Download
M cc/layer_tree_host.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M cc/layer_tree_host.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M cc/layer_tree_host_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M cc/layer_tree_host_impl.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M cc/occlusion_tracker.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/occlusion_tracker.cc View 5 chunks +16 lines, -3 lines 0 comments Download
M cc/switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/switches.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
danakj
8 years, 1 month ago (2012-11-13 03:56:50 UTC) #1
danakj
+jam for content/
8 years, 1 month ago (2012-11-13 03:57:03 UTC) #2
jam
lgtm
8 years, 1 month ago (2012-11-13 16:13:12 UTC) #3
danakj
ping @ enne/jamesr
8 years, 1 month ago (2012-11-14 19:33:54 UTC) #4
enne (OOO)
lgtm
8 years, 1 month ago (2012-11-14 19:58:26 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-14 22:40:20 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698