ui: Make gfx::Size::Scale() mutate the class. Add gfx::ScaleSize() similar to Rect/Point.

ui/gfx/rect_f.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_RECT_F_H_
 #define UI_GFX_RECT_F_H_
 
 #include <string>
 
 #include "ui/gfx/point_f.h"
@@ skipping 10 matching lines @@
     : public RectBase<RectF, PointF, SizeF, InsetsF, Vector2dF, float> {
  public:
   RectF();
   RectF(float width, float height);
   RectF(float x, float y, float width, float height);
   explicit RectF(const gfx::SizeF& size);
   RectF(const gfx::PointF& origin, const gfx::SizeF& size);
 
   ~RectF();
 
   /// Scales the rectangle by |scale|.

[tfarina, 2012/11/09 13:05:37]

nit: just two //

[danakj, 2012/11/09 16:11:38]

Done.

   void Scale(float scale) {
     Scale(scale, scale);
   }
 
   void Scale(float x_scale, float y_scale) {
     set_origin(ScalePoint(origin(), x_scale, y_scale));
-
-    SizeF newSize = size().Scale(x_scale, y_scale);

[tfarina, 2012/11/09 13:05:37]

nit: newSize, tisk, tisk :(

s/newSize/new_size.

[danakj, 2012/11/09 16:11:38]

I'm removing this code.

-    set_size(newSize);
+    set_size(ScaleSize(size(), x_scale, y_scale));
   }
 
   // This method reports if the RectF can be safely converted to an integer
   // Rect. When it is false, some dimension of the RectF is outside the bounds
   // of what an integer can represent, and converting it to a Rect will require
   // clamping.
   bool IsExpressibleAsRect() const;
 
   std::string ToString() const;
 };
@@ skipping 23 matching lines @@
 // contained within the rect, because they will appear on one of these edges.
 UI_EXPORT RectF BoundingRect(const PointF& p1, const PointF& p2);
 
 #if !defined(COMPILER_MSVC)
 extern template class RectBase<RectF, PointF, SizeF, InsetsF, Vector2dF, float>;
 #endif
 
 }  // namespace gfx
 
 #endif  // UI_GFX_RECT_F_H_