Moving prepopulated search engines to a JSON file.

chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc

Index: chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc
diff --git a/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc b/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc
index 324af6e2bed86e996ea3cbe88129f521a7735aa0..ec1c3879a976e38e97d8019711ba87b07535e255 100644
--- a/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc
+++ b/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc
@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/memory/scoped_vector.h"
 #include "base/scoped_temp_dir.h"
@@ -10,6 +11,7 @@
 #include "chrome/browser/search_engines/template_url.h"
 #include "chrome/browser/search_engines/template_url_service.h"
 #include "chrome/browser/search_engines/template_url_prepopulate_data.h"
+#include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_pref_service.h"
 #include "chrome/test/base/testing_profile.h"
@@ -177,6 +179,44 @@ TEST(TemplateURLPrepopulateDataTest, ProvidersFromPrefs) {
   EXPECT_EQ(2u, t_urls.size());
 }
 
+// Verifies that built-in search providers are processed correctly.
+TEST(TemplateURLPrepopulateDataTest, ProvidersFromPrepopulated) {

[Peter Kasting, 2012/11/13 22:42:45]

This test is really fragile and will break every time we touch the Google entry,
which is frequently.

I'd actually rather have no test than this test.  If we have a test, it should
be very general, e.g. ensure that there are more than zero engines defined, and
they all have names and search URLs.  Something basic like that.

[beaudoin, 2012/11/14 17:34:12]

I've kept the test but made it much less brittle. This is the one that caught my
bug about the alternate_urls size being wrong, and this could be a really hard
one to catch/witness otherwise.

I've removed tests for things that were already verified by the python unit
tests. I still check the default is "Google" because it's the only engine with
some alternate_urls and if we ever change the default engine for the US I'd
rather have a failure for "Google" than for the number of alternate_urls.

+  // Use Norway to test some unicode characters.
+  CommandLine::ForCurrentProcess()->AppendSwitchASCII(
+      switches::kCountry, "NO");
+  TestingProfile profile;
+  ScopedVector<TemplateURL> t_urls;
+  size_t default_index;
+  TemplateURLPrepopulateData::GetPrepopulatedEngines(&profile, &t_urls.get(),
+                                                     &default_index);
+  ASSERT_EQ(0u, default_index);
+  ASSERT_EQ(5u, t_urls.size());
+  EXPECT_EQ(ASCIIToUTF16("Google"), t_urls[0]->short_name());
+  EXPECT_EQ(ASCIIToUTF16("google.com"), t_urls[0]->keyword());
+  EXPECT_EQ("www.google.com", t_urls[0]->url_ref().GetHost());
+  EXPECT_EQ("http://www.google.com/favicon.ico",
+            t_urls[0]->favicon_url().spec());
+  EXPECT_EQ(1u, t_urls[0]->input_encodings().size());
+  EXPECT_EQ("UTF-8", t_urls[0]->input_encodings()[0]);
+  EXPECT_EQ(1, t_urls[0]->prepopulate_id());
+  EXPECT_EQ("{google:baseSuggestURL}search?{google:searchFieldtrialParameter}"
+            "client=chrome&q={searchTerms}&"
+            "sugkey={google:suggestAPIKeyParameter}",
+            t_urls[0]->suggestions_url());
+  EXPECT_EQ("{google:baseURL}webhp?sourceid=chrome-instant&{google:RLZ}"
+            "{google:instantEnabledParameter}ie={inputEncoding}",
+            t_urls[0]->instant_url());
+  EXPECT_EQ("{google:baseURL}#q={searchTerms}",
+            t_urls[0]->alternate_urls()[0]);
+  EXPECT_EQ("{google:baseURL}search#q={searchTerms}",
+            t_urls[0]->alternate_urls()[1]);
+  EXPECT_EQ("{google:baseURL}webhp#q={searchTerms}",
+            t_urls[0]->alternate_urls()[2]);
+
+  // Testing unicode characters work correctly.
+  EXPECT_EQ(WideToUTF16(L"ABC S\x00f8k"), t_urls[2]->short_name());
+}
+
 TEST(TemplateURLPrepopulateDataTest, GetEngineTypeBasic) {
   EXPECT_EQ(SEARCH_ENGINE_OTHER,
             TemplateURLPrepopulateData::GetEngineType("http://example.com/"));