Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6971)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 11377045: Removing cruft. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comment. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index e21d588f33cd0f8090ec68468009834a69fb5643..d4f5a465ae7c6bb26bfd137189799e2023fc4993 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -975,15 +975,21 @@ bool ChromeContentRendererClient::CrossesExtensionExtents(
should_consider_workaround);
}
-void ChromeContentRendererClient::OnPurgeMemory() {
- DVLOG(1) << "Resetting spellcheck in renderer client";
+void ChromeContentRendererClient::SetSpellcheck(SpellCheck* spellcheck) {
RenderThread* thread = RenderThread::Get();
- if (spellcheck_.get())
+ if (spellcheck_.get() && thread)
thread->RemoveObserver(spellcheck_.get());
- spellcheck_.reset(new SpellCheck());
+ spellcheck_.reset(spellcheck);
SpellCheckReplacer replacer(spellcheck_.get());
content::RenderView::ForEach(&replacer);
- thread->AddObserver(spellcheck_.get());
+ if (thread)
+ thread->AddObserver(spellcheck_.get());
+}
+
sky 2012/11/12 03:51:37 nit: remove one line.
groby-ooo-7-16 2012/11/13 02:05:15 Done.
+
+void ChromeContentRendererClient::OnPurgeMemory() {
+ DVLOG(1) << "Resetting spellcheck in renderer client";
+ SetSpellcheck(new SpellCheck());
}
bool ChromeContentRendererClient::IsAdblockInstalled() {

Powered by Google App Engine
This is Rietveld 408576698