Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 11377023: Revert 166369 - Revert 166365 - roll clang 165787:167488 (Closed)

Created:
8 years, 1 month ago by pastarmovj
Modified:
8 years, 1 month ago
Reviewers:
Julian Pastarmov
CC:
chromium-reviews, fischman+watch_chromium.org, glotov+watch_chromium.org, pam+watch_chromium.org, ukai+watch_chromium.org, dmikurube+clang_chromium.org
Visibility:
Public.

Description

Revert 166369 - Revert 166365 - roll clang 165787:167488 Seems like a clobber might be enough to fix the issues caused by this CL. Reverted because it is assumed to be the cause for multiple compile failures on mac and linux. Fixes crash in arm codegen. Doesn't warn on -Wno-arc-abi. Nicer diagnostics for nested macro instantiations. Includes asan support for android on linux (shout if you need that on mac). Fixes issue with debug information in .S files. Renames -faddress-sanitizer to -fsanitize=address (continue to use -faddress-sanitizer in chromium for now, until we've updated all third-party gyp files) BUG=159712, 159452, 159475, 159502, 159598, 59580 TBR=hans Review URL: https://codereview.chromium.org/11361133 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/11377020 TBR=pastarmovj@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M build/common.gypi View 4 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_cocoa_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/scripts/update.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
pastarmovj
8 years, 1 month ago (2012-11-07 12:52:27 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698