Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Issue 1137693006: Revert of Fix missing GN dependencies. (Closed)

Created:
5 years, 7 months ago by brettw
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, samuong+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stgao, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix missing GN dependencies. (patchset #4 id:60001 of https://codereview.chromium.org/1128163007/) Reason for revert: Broke Windows: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/1568/steps/compile/logs/stdio Original issue's description: > Fix missing GN dependencies. > > Fixes some cases where a dependency between a target's inputs and outputs exists without an explicit dependency. > > json_schema_api.gni was generating wrong names, this was fixed. > > mojo_application_package.gni was fixed to generate unique names (just a bug I noticed in passing) and support the testonly flag, which is necessary when I added the correct dependency. > > The rest of the cases are just adding deps or making existing deps public so that the ability to depend on the target's outputs is passed to dependents. > > BUG=487897 > > Committed: https://crrev.com/eadea21096be21b0d74c93f5b1a0ae6a9cc057d7 > Cr-Commit-Position: refs/heads/master@{#330636} TBR=dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=487897 Committed: https://crrev.com/e97185bf4853d56aadf362b0a00699375b1fac76 Cr-Commit-Position: refs/heads/master@{#330650}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -53 lines) Patch
M build/json_schema_api.gni View 2 chunks +4 lines, -6 lines 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/BUILD.gn View 6 chunks +2 lines, -19 lines 0 comments Download
M chrome/app/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/chromedriver/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M gin/BUILD.gn View 2 chunks +4 lines, -6 lines 0 comments Download
M mojo/mojo_application_package.gni View 1 chunk +2 lines, -7 lines 0 comments Download
M ui/resources/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
Created Revert of Fix missing GN dependencies.
5 years, 7 months ago (2015-05-19 23:12:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137693006/1
5 years, 7 months ago (2015-05-19 23:13:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 23:14:41 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e97185bf4853d56aadf362b0a00699375b1fac76 Cr-Commit-Position: refs/heads/master@{#330650}
5 years, 7 months ago (2015-05-19 23:16:38 UTC) #4
Dirk Pranke
5 years, 7 months ago (2015-05-20 01:28:25 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698