Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1137683004: Add top-level webkit/ directory to .gitignore. (Closed)

Created:
5 years, 7 months ago by joelo
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke, jsbell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add top-level webkit/ directory to .gitignore. Layout tests generate results in the webkit/ folder which was recently removed from the chromium tree. BUG=488288 Committed: https://crrev.com/7143a2e9dea474822d945d1de28c7192964e5bbb Cr-Commit-Position: refs/heads/master@{#330431}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix order and add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M .gitignore View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
joelo
jsbell@, dpranke@ -- PTAL :)
5 years, 7 months ago (2015-05-18 10:14:09 UTC) #2
Dirk Pranke
lgtm w/ fix. https://codereview.chromium.org/1137683004/diff/1/.gitignore File .gitignore (right): https://codereview.chromium.org/1137683004/diff/1/.gitignore#newcode433 .gitignore:433: /webkit nit: "webkit" sorts before "webpage" ...
5 years, 7 months ago (2015-05-18 20:41:35 UTC) #3
jsbell
Please add a comment above the line explaining why it exists/linking to bug. e.g. # ...
5 years, 7 months ago (2015-05-18 20:43:04 UTC) #4
joelo
On 2015/05/18 20:43:04, jsbell wrote: > Please add a comment above the line explaining why ...
5 years, 7 months ago (2015-05-18 21:32:50 UTC) #5
joelo
https://codereview.chromium.org/1137683004/diff/1/.gitignore File .gitignore (right): https://codereview.chromium.org/1137683004/diff/1/.gitignore#newcode433 .gitignore:433: /webkit On 2015/05/18 20:41:35, Dirk Pranke wrote: > nit: ...
5 years, 7 months ago (2015-05-18 21:33:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137683004/20001
5 years, 7 months ago (2015-05-18 21:35:48 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-18 21:44:24 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:44:07 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7143a2e9dea474822d945d1de28c7192964e5bbb
Cr-Commit-Position: refs/heads/master@{#330431}

Powered by Google App Engine
This is Rietveld 408576698