Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2799)

Unified Diff: content/renderer/pepper/pepper_webplugin_impl.cc

Issue 1137663006: Fix WebViewPlugin::scheduleAnimation crash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reset throttler_ in PepperPluginInstanceImpl Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/pepper_plugin_instance_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/pepper_webplugin_impl.cc
diff --git a/content/renderer/pepper/pepper_webplugin_impl.cc b/content/renderer/pepper/pepper_webplugin_impl.cc
index 0caa190b0461432f89bd11635f5dde6646099123..a7b8cec01ea6401d8d05e2f0253c6392607f18e0 100644
--- a/content/renderer/pepper/pepper_webplugin_impl.cc
+++ b/content/renderer/pepper/pepper_webplugin_impl.cc
@@ -124,6 +124,7 @@ void PepperWebPluginImpl::destroy() {
// Tell |container_| to clear references to this plugin's script objects.
if (container_)
container_->clearScriptObjects();
+ container_ = nullptr;
raymes 2015/05/12 00:36:30 I'm not sure that this will actually have any impa
trchen 2015/05/12 01:35:33 Yes I think you're right. Accessing a destroyed pl
if (instance_.get()) {
ppapi::PpapiGlobals::Get()->GetVarTracker()->ReleaseVar(instance_object_);
@@ -131,6 +132,7 @@ void PepperWebPluginImpl::destroy() {
instance_->Delete();
instance_ = NULL;
}
+ throttler_.reset();
base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);
}
« no previous file with comments | « content/renderer/pepper/pepper_plugin_instance_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698