Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1137663004: Don't issue texture barriers for RT's with separate storage (Closed)

Created:
5 years, 7 months ago by Chris Dalton
Modified:
5 years, 7 months ago
Reviewers:
egdaniel, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@upload_oreq
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't issue texture barriers for RT's with separate storage BUG=skia: Committed: https://skia.googlesource.com/skia/+/231c5fd590c898957d65cbfbc51040c7fe236af6

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : comment #

Patch Set 4 : rebase #

Patch Set 5 : New approach #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M src/gpu/GrCommandBuilder.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpu.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTargetCommands.h View 1 2 3 4 1 chunk +7 lines, -1 line 0 comments Download
M src/gpu/GrTargetCommands.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 3 4 5 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Chris Dalton
5 years, 7 months ago (2015-05-08 22:31:06 UTC) #2
bsalomon
On 2015/05/08 22:31:06, Chris Dalton wrote: I like this better, too. We can live with ...
5 years, 7 months ago (2015-05-13 13:31:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137663004/80001
5 years, 7 months ago (2015-05-13 18:53:45 UTC) #5
commit-bot: I haz the power
Failed to apply patch for tests/GLProgramsTest.cpp: While running git apply --index -3 -p1; error: patch ...
5 years, 7 months ago (2015-05-13 18:53:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137663004/100001
5 years, 7 months ago (2015-05-13 19:17:44 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 19:35:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/231c5fd590c898957d65cbfbc51040c7fe236af6

Powered by Google App Engine
This is Rietveld 408576698