Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 1137633003: Add ONC property for EAP-GTC authentication (Closed)

Created:
5 years, 7 months ago by Paul Stewart
Modified:
5 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ONC property for EAP-GTC authentication BUG=486738 R=stevenjb@chromium.org, pneubeck@chromium.org Committed: https://crrev.com/eba91db036f740777ff8503cc2cc2597e8525353 Cr-Commit-Position: refs/heads/master@{#329291}

Patch Set 1 #

Patch Set 2 : Added ONC validator #

Patch Set 3 : Add to onc_constants.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chromeos/network/onc/onc_translation_tables.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chromeos/network/onc/onc_validator.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/onc/docs/onc_spec.html View 1 chunk +2 lines, -2 lines 0 comments Download
M components/onc/onc_constants.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/onc/onc_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Paul Stewart
5 years, 7 months ago (2015-05-11 15:33:48 UTC) #1
pneubeck (no reviews)
you need to add the value also to the validator: https://code.google.com/p/chromium/codesearch#chromium/src/chromeos/network/onc/onc_validator.cc&l=883 after that lgtm
5 years, 7 months ago (2015-05-11 17:11:38 UTC) #2
Paul Stewart
I'll set a commit flag after I roll forward service_constants in a separate CL (constants ...
5 years, 7 months ago (2015-05-11 17:22:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137633003/20001
5 years, 7 months ago (2015-05-11 22:46:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/36417) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 7 months ago (2015-05-11 23:03:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137633003/40001
5 years, 7 months ago (2015-05-11 23:22:18 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-12 00:18:21 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 00:19:19 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/eba91db036f740777ff8503cc2cc2597e8525353
Cr-Commit-Position: refs/heads/master@{#329291}

Powered by Google App Engine
This is Rietveld 408576698