Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 113763003: Add use_clibpard_aurax11 gyp flag to allow chromeos-chrome to access X11 Clipboard (Closed)

Created:
7 years ago by oshima
Modified:
7 years ago
Reviewers:
tony, Elliot Glaysher
CC:
chromium-reviews, dcheng
Visibility:
Public.

Description

Add use_clibpard_aurax11 gyp flag to allow chromeos-chrome to access X11 Clipboard I made this a gyp flag instead of command line flag to avoid linking this on production. BUG=153978 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240465

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M build/common.gypi View 1 5 chunks +12 lines, -0 lines 0 comments Download
M ui/base/clipboard/clipboard.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ui.gyp View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
oshima
7 years ago (2013-12-12 11:40:16 UTC) #1
tony
https://codereview.chromium.org/113763003/diff/60001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/113763003/diff/60001/build/common.gypi#newcode40 build/common.gypi:40: 'use_clipboard_aurax11%': 0, You don't need to define this at ...
7 years ago (2013-12-12 17:38:20 UTC) #2
oshima
uploaded new patch. PTAL.
7 years ago (2013-12-12 18:54:08 UTC) #3
tony
LGTM
7 years ago (2013-12-12 19:00:32 UTC) #4
Elliot Glaysher
lgtm The clipboard implementation is still a bit incomplete though.
7 years ago (2013-12-12 19:12:48 UTC) #5
oshima
On 2013/12/12 19:12:48, Elliot Glaysher wrote: > lgtm > > The clipboard implementation is still ...
7 years ago (2013-12-12 19:25:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/113763003/80001
7 years ago (2013-12-12 19:32:10 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-12 23:06:53 UTC) #8
Message was sent while issue was closed.
Change committed as 240465

Powered by Google App Engine
This is Rietveld 408576698