Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1137623007: [iOS] Upstream changes to swipe recognizer (Closed)

Created:
5 years, 7 months ago by sdefresne
Modified:
5 years, 7 months ago
CC:
chromium-reviews, justincohen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Upstream changes to swipe recognizer Update swipe recognizer to differentiate between edge/non-edge swipes. BUG=None Committed: https://crrev.com/46439ad2021110ab9cbed34a8d7e04fe41008ae9 Cr-Commit-Position: refs/heads/master@{#330355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M ios/chrome/browser/ui/side_swipe_gesture_recognizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/side_swipe_gesture_recognizer.mm View 4 chunks +21 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
sdefresne
Please take a look. justincohen: FYI
5 years, 7 months ago (2015-05-18 13:50:11 UTC) #2
sdefresne
Note that this is upstreaming a downstream CL.
5 years, 7 months ago (2015-05-18 13:54:59 UTC) #3
noyau (Ping after 24h)
lgtm, but please change the description to match the content of the CL as discussed ...
5 years, 7 months ago (2015-05-18 13:56:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137623007/1
5 years, 7 months ago (2015-05-18 13:58:41 UTC) #6
sdefresne
Done. Thank you for the review.
5 years, 7 months ago (2015-05-18 13:58:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 14:05:41 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 14:06:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46439ad2021110ab9cbed34a8d7e04fe41008ae9
Cr-Commit-Position: refs/heads/master@{#330355}

Powered by Google App Engine
This is Rietveld 408576698