[android] Handle re-issued cards in unmasking prompt.

[android] Handle re-issued cards in unmasking prompt.

BUG=487866
Committed: https://crrev.com/2ec417add5462615360fef99aa827bdfde0f09ca
Cr-Commit-Position: refs/heads/master@{#330857}

[Evan Stade, 2015-05-15 23:11:36]

estade@chromium.org changed reviewers:
+ aurimas@chromium.org

[aurimas (slooooooooow), 2015-05-18 20:41:13]

https://codereview.chromium.org/1137623006/diff/40001/chrome/android/java/res...
File chrome/android/java/res/layout/autofill_card_unmask_prompt.xml (right):

https://codereview.chromium.org/1137623006/diff/40001/chrome/android/java/res...
chrome/android/java/res/layout/autofill_card_unmask_prompt.xml:71: <EditText
Just a random comment: can you try long pressing on any of EditText in this
dialog to try to copy text on pre-L device? I am almost certain you will hit
crbug.com/484658 bug where the context menu to copy/cut/paste will not be
clickable.

https://codereview.chromium.org/1137623006/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java
(right):

https://codereview.chromium.org/1137623006/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java:176:
initExpirationDateInputs();
We do need to init these every time? It sounds like the name is not very
accurate. Maybe it should be showExpirationDateInputs?

https://codereview.chromium.org/1137623006/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java:309:
mCardUnmaskInput.setText(new String());
Can you just call setText(null)?

[Evan Stade, 2015-05-18 22:25:45]

https://codereview.chromium.org/1137623006/diff/40001/chrome/android/java/res...
File chrome/android/java/res/layout/autofill_card_unmask_prompt.xml (right):

https://codereview.chromium.org/1137623006/diff/40001/chrome/android/java/res...
chrome/android/java/res/layout/autofill_card_unmask_prompt.xml:71: <EditText
On 2015/05/18 20:41:12, aurimas wrote:
> Just a random comment: can you try long pressing on any of EditText in this
> dialog to try to copy text on pre-L device? I am almost certain you will hit
> crbug.com/484658 bug where the context menu to copy/cut/paste will not be
> clickable.

yep, that happens

https://codereview.chromium.org/1137623006/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java
(right):

https://codereview.chromium.org/1137623006/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java:176:
initExpirationDateInputs();
On 2015/05/18 20:41:12, aurimas wrote:
> We do need to init these every time? It sounds like the name is not very
> accurate. Maybe it should be showExpirationDateInputs?

Done.

https://codereview.chromium.org/1137623006/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java:309:
mCardUnmaskInput.setText(new String());
On 2015/05/18 20:41:12, aurimas wrote:
> Can you just call setText(null)?

Done.

[aurimas (slooooooooow), 2015-05-19 20:31:42]

lgtm

[Evan Stade, 2015-05-19 21:27:34]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-05-19 21:28:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137623006/60001

[commit-bot: I haz the power, 2015-05-19 21:34:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-19 21:34:14]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Evan Stade, 2015-05-20 23:37:55]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-05-20 23:37:55]

The patchset sent to the CQ was uploaded after l-g-t-m from aurimas@chromium.org
Link to the patchset: https://codereview.chromium.org/1137623006/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2015-05-20 23:39:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137623006/80001

[commit-bot: I haz the power, 2015-05-21 00:12:42]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-21 00:13:35]

Patchset 5 (id:??) landed as
https://crrev.com/2ec417add5462615360fef99aa827bdfde0f09ca
Cr-Commit-Position: refs/heads/master@{#330857}