Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1137623005: Remove WebElement::innerText. (Closed)

Created:
5 years, 7 months ago by dglazkov
Modified:
5 years, 7 months ago
Reviewers:
esprehn
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Remove WebElement::innerText. This is the final part 3. BUG=488088 R=esprehn Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195421 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M Source/web/WebElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebElement.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
dglazkov
5 years, 7 months ago (2015-05-15 20:43:14 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137623005/1
5 years, 7 months ago (2015-05-15 20:43:19 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-15 21:59:19 UTC) #5
esprehn
Link to a tracking bug? I guess you landed the other parts already? Lgtm
5 years, 7 months ago (2015-05-15 22:18:09 UTC) #6
dglazkov
On 2015/05/15 at 22:18:09, esprehn wrote: > Link to a tracking bug? I guess you ...
5 years, 7 months ago (2015-05-15 22:20:02 UTC) #7
esprehn
lgtm
5 years, 7 months ago (2015-05-15 22:21:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137623005/1
5 years, 7 months ago (2015-05-15 22:21:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=195421
5 years, 7 months ago (2015-05-15 22:25:45 UTC) #11
Ken Russell (switch to Gerrit)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1139603004/ by kbr@chromium.org. ...
5 years, 7 months ago (2015-05-15 22:47:42 UTC) #12
dglazkov
On 2015/05/15 at 22:47:42, kbr wrote: > A revert of this CL (patchset #1 id:1) ...
5 years, 7 months ago (2015-05-15 23:14:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137623005/1
5 years, 7 months ago (2015-05-15 23:15:08 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 23:18:22 UTC) #16
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195426

Powered by Google App Engine
This is Rietveld 408576698