Cache listener extension ids.

Cache listener extension ids.

Previously launcherSearchProvider API has always enumerated all enabled extensions to list up listener extensions.
This CL changes to cache the list.

BUG=488329
Committed: https://crrev.com/74bc4baecb50a984e9336cf5514addb6900e1f9c
Cr-Commit-Position: refs/heads/master@{#330478}

[yawano, 2015-05-14 11:26:45]

yawano@chromium.org changed reviewers:
+ mgiuca@chromium.org, satorux@chromium.org

[yawano, 2015-05-14 11:26:45]

@mgiuca, @satorux: PTAL. Thank you!

[Matt Giuca, 2015-05-15 02:05:21]

lgtm.

I think now that this feature is implemented, it would be helpful to stop using
that main bug ID 440649. For future issues, you should file new bugs and link to
the CL. This way, reviewers can see exactly what problem you're trying to solve
now, as opposed to simply that it's related to files search.

https://codereview.chromium.org/1137603005/diff/1/chrome/browser/chromeos/lau...
File chrome/browser/chromeos/launcher_search_provider/service.cc (right):

https://codereview.chromium.org/1137603005/diff/1/chrome/browser/chromeos/lau...
chrome/browser/chromeos/launcher_search_provider/service.cc:156: if
(cached_listener_extension_ids_ != nullptr)
if (cached_listener_extension_ids_)

https://codereview.chromium.org/1137603005/diff/1/chrome/browser/chromeos/lau...
chrome/browser/chromeos/launcher_search_provider/service.cc:159:
cached_listener_extension_ids_ = make_scoped_ptr(new std::set<ExtensionId>());
.reset(new std::set<>);

[yawano, 2015-05-15 03:39:09]

@mgiuca: Thank you for the review! Updated the BUG= with a new issue.

https://codereview.chromium.org/1137603005/diff/1/chrome/browser/chromeos/lau...
File chrome/browser/chromeos/launcher_search_provider/service.cc (right):

https://codereview.chromium.org/1137603005/diff/1/chrome/browser/chromeos/lau...
chrome/browser/chromeos/launcher_search_provider/service.cc:156: if
(cached_listener_extension_ids_ != nullptr)
On 2015/05/15 02:05:21, Matt Giuca wrote:
> if (cached_listener_extension_ids_)

Done.

https://codereview.chromium.org/1137603005/diff/1/chrome/browser/chromeos/lau...
chrome/browser/chromeos/launcher_search_provider/service.cc:159:
cached_listener_extension_ids_ = make_scoped_ptr(new std::set<ExtensionId>());
On 2015/05/15 02:05:21, Matt Giuca wrote:
> .reset(new std::set<>);

Done.

[Matt Giuca, 2015-05-15 06:50:02]

Thanks!

[satorux1, 2015-05-19 03:09:27]

the description looks too short. please have some explanation on what the change
is for

[yawano, 2015-05-19 03:12:36]

@satorux: Added more explanation to CL description. PTAL. Thank you!

[satorux1, 2015-05-19 03:16:37]

LGTM

[yawano, 2015-05-19 03:17:00]

On 2015/05/19 03:16:37, satorux1 wrote:
> LGTM

Thank you!

[yawano, 2015-05-19 03:17:03]

The CQ bit was checked by yawano@chromium.org

[yawano, 2015-05-19 03:17:04]

The patchset sent to the CQ was uploaded after l-g-t-m from mgiuca@chromium.org
Link to the patchset: https://codereview.chromium.org/1137603005/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2015-05-19 03:17:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137603005/20001

[commit-bot: I haz the power, 2015-05-19 03:53:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-19 03:54:21]

Patchset 2 (id:??) landed as
https://crrev.com/74bc4baecb50a984e9336cf5514addb6900e1f9c
Cr-Commit-Position: refs/heads/master@{#330478}