Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1137593002: Remove SVGElement.xmlbase/xmlspace/xmllang and no use codes. (Closed)

Created:
5 years, 7 months ago by hyunjunekim2
Modified:
5 years, 7 months ago
Reviewers:
pdr., philipj_slow, fs
CC:
blink-reviews, krit, arv+blink, vivekg_samsung, kouhei+svg_chromium.org, fs, vivekg, f(malita), Inactive, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove SVGElement.xmlbase/xmlspace/xmllang and no use codes. Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/TfwMq4d25hk/C-v_iC_wKfAJ And remove that don't use codes on SVGElement::parseAttribute(), Because it is safe as SVGElement::parseAttribute() does nothing with xml:lang and xml:space. BUG=485676 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195291

Patch Set 1 : Draft 1 #

Patch Set 2 : Modify test. #

Patch Set 3 : Modify test(2) #

Patch Set 4 : Modify test(3) #

Total comments: 2

Patch Set 5 : Draft 2 #

Patch Set 6 : Draft 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -29 lines) Patch
M LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M Source/bindings/scripts/v8_attributes.py View 1 2 3 4 1 chunk +1 line, -7 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGElement.idl View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hyunjunekim2
Hi, I'm hyunjunekim (hyunjune.kim@samsung.com, hykim0777@gamil.com). Could you check this patch? Thank you.
5 years, 7 months ago (2015-05-08 07:55:08 UTC) #2
philipj_slow
Thanks! I've updated the description to point to the blink-dev thread, which needs 2 more ...
5 years, 7 months ago (2015-05-08 08:09:25 UTC) #3
hyunjunekim2
> Can you also clean up in the bindings generator? Search for "SVG's > xmlbase/xmlspace/xmllang ...
5 years, 7 months ago (2015-05-08 09:17:26 UTC) #4
philipj_slow
PS6 LGTM, but please wait for the last LGTM on blink-dev before landing.
5 years, 7 months ago (2015-05-08 21:20:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137593002/100001
5 years, 7 months ago (2015-05-13 01:00:47 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 03:06:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195291

Powered by Google App Engine
This is Rietveld 408576698