Add field trial to only use the secure Data Reduction Proxy on a successful secure proxy check.

Add field trial to only use the secure Data Reduction Proxy on a successful secure proxy check.

This permits determining the impact on HTTP vs HTTPS Data Reduction Proxy
use by changing the secure proxy check behavior (per the changelist
https://codereview.chromium.org/1132083004/).

BUG=466753
Committed: https://crrev.com/9de69c4c1629be23188010d34d68d95d10cf1ae6
Cr-Commit-Position: refs/heads/master@{#330187}

[jeremyim, 2015-05-15 03:41:49]

jeremyim@chromium.org changed reviewers:
+ bengr@chromium.org

[jeremyim, 2015-05-15 03:41:50]

PTAL.

Thanks!

[bengr, 2015-05-15 19:26:23]

lgtm with nit.

https://codereview.chromium.org/1137583004/diff/1/components/data_reduction_p...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
(right):

https://codereview.chromium.org/1137583004/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:154:
if (FieldTrialList::FindFullName(kSecureProxyCheckDefaultFieldTrial) ==
nit: Since you only refer to the const char here, why define it?

[jeremyim, 2015-05-15 19:32:34]

The CQ bit was checked by jeremyim@chromium.org

[jeremyim, 2015-05-15 19:32:34]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org
Link to the patchset: https://codereview.chromium.org/1137583004/#ps20001
(title: "CR comment")

[jeremyim, 2015-05-15 19:33:05]

https://codereview.chromium.org/1137583004/diff/1/components/data_reduction_p...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
(right):

https://codereview.chromium.org/1137583004/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:154:
if (FieldTrialList::FindFullName(kSecureProxyCheckDefaultFieldTrial) ==
On 2015/05/15 19:26:23, bengr wrote:
> nit: Since you only refer to the const char here, why define it?

Done.

[commit-bot: I haz the power, 2015-05-15 19:35:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137583004/20001

[commit-bot: I haz the power, 2015-05-15 20:31:47]

Committed patchset #2 (id:20001)

[325583992843-0clp48nf3nc7pk3ll9lp3k65k4ra53j4, 2015-05-16 05:38:47]

Patchset 2 (id:??) landed as
https://crrev.com/9de69c4c1629be23188010d34d68d95d10cf1ae6
Cr-Commit-Position: refs/heads/master@{#330187}

[commit-bot: I haz the power, 2015-05-18 11:27:03]

Patchset 2 (id:??) landed as
https://crrev.com/9de69c4c1629be23188010d34d68d95d10cf1ae6
Cr-Commit-Position: refs/heads/master@{#330187}