chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm - Issue 1137543004: [Permission Bubble] Allow re-display after ESC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

Issue 1137543004: [Permission Bubble] Allow re-display after ESC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

index 1dd508e0844a6eee06b48c2483583b3b770ebc2f..05bff6d36a603812e13e27e3ce83fa73841f8e39 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

@@ -248,6 +248,9 @@ class MenuDelegate : public ui::SimpleMenuModel::Delegate {

- (void)windowWillClose:(NSNotification*)notification {

bridge_->OnBubbleClosing();

[super windowWillClose:notification];

+ if (delegate_)

+ delegate_->Closing();

}

- (void)parentWindowWillBecomeFullScreen:(NSNotification*)notification {

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm » ('j') | no next file with comments »